fix(smoke): time out the full VHS process group#1655
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
July 15, 2026 14:42
Aaronontheweb
force-pushed
the
fix/vhs-timeout-process-group
branch
from
July 15, 2026 14:56
ae367b5 to
7bcf7b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
The macOS native-smoke job on Dependabot PR #1649 hung while starting
config-workspaces-picker: VHS printed only the tape filename, executed no tape commands, ignored the nominal 600-second limit, and consumed the full 45-minute job budget.Root cause
run-native-tape.shinvokes GNU timeout with--foreground. GNU documents that foreground mode does not time out child processes. VHS supervises ttyd/browser children, so a stuck child can survive the deadline and keep the harness blocked.Fix
Run VHS in timeout’s separate process group and add
--kill-after=10s. The full VHS child tree now receives the timeout signal, with a bounded escalation to SIGKILL, allowing the existing failure-artifact path to run deterministically.Validation
bash -n scripts/smoke/run-native-tape.shgit diff --check upstream/dev...HEADThe PR smoke workflow supplies the required Linux and macOS native-tape validation.