fix(reminders): rescan definitions before startup alerts#1653
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
July 15, 2026 14:36
Aaronontheweb
force-pushed
the
fix/reminder-startup-rescan-schema-alerts
branch
from
July 15, 2026 14:55
e9fd87b to
835b00c
Compare
This was referenced Jul 16, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
Startup_emits_alert_for_legacy_reminder_missing_trust_fieldsintermittently observed an empty notification sink even after the actor answered its readiness query. The mailbox barrier provesPreStartcompleted, so this is not an assertion-delay problem: startup relied on a schema scan performed earlier by the store constructor and then consumed a one-shot rejection list.Fix
Rescan reminder definitions at the actor startup boundary, immediately before consuming and emitting schema alerts. This uses the existing
ReminderDefinitionStore.List()path, which records legacy trust-field rejections and de-duplicates them by reminder ID.Validation
dotnet test src/Netclaw.Actors.Tests/Netclaw.Actors.Tests.csproj -c Release --filter FullyQualifiedName~Startup_emits_alert --no-restoredotnet slopwatch analyzepwsh ./scripts/Add-FileHeaders.ps1 -Verify