refactor(tools): fork typed subagent execution context#1644
Merged
Conversation
Collaborator
Author
|
Independent architecture review initially held this PR on three issues. Commit
The reviewer re-reviewed the commit and returned a merge verdict with no blocking behavior drift. Local validation after the repair: Actors 2617/2617; full solution green; Slopwatch 0; headers, strict OpenSpec, and diff checks pass. |
This was referenced Jul 15, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChildRunScope, with independent child activity stateBehavior contract
This is a behavior-preserving architecture refactor. MCP schemas and persisted actor contracts are unchanged. Public turns still never inspect Git. Git failure remains non-fatal and visibly unavailable. Successful/partial children retain confirmed-file handoff; failed/cancelled children cannot update parent context.
Validation
dotnet test Netclaw.slnx --no-restore— all runnable tests pass (Actors 2613, Daemon 827, CLI 1252, plus supporting projects; environment-gated integration tests skipped)dotnet slopwatch analyze— 0 issuespwsh ./scripts/Add-FileHeaders.ps1 -Verify— passopenspec validate simplify-tool-execution-context --strict— validgit diff --check— passThe behavioral eval harness cannot run locally because no eval provider type, endpoint, or model credentials are configured. The dotnet-skills CRAP collector workflow is unavailable because this repository does not include the XPlat coverage collector; the full actor assembly passes.
Advances #1633. The issue will be closed after merge and post-merge acceptance verification.