Use logical skill access and authoritative inventory refresh#1634
Conversation
Aaronontheweb
left a comment
There was a problem hiding this comment.
LGTM but just want to know about #1552
| Assert.Empty(refresher.Refresh().AcceptedSkills); | ||
|
|
||
| WriteSkill(_paths.ServerFeedDirectory("managed"), "feed-skill", "managed guidance"); | ||
| var result = refresher.Refresh(); |
| var byFile = new Dictionary<string, SkillEntry>(StringComparer.OrdinalIgnoreCase); | ||
| var slashCommands = new Dictionary<string, SkillEntry>(StringComparer.OrdinalIgnoreCase); | ||
|
|
||
| foreach (var skill in skillList) |
There was a problem hiding this comment.
no collision handling for duplicate skills here - do we need it or does it happen elsewhere?
There was a problem hiding this comment.
Collision handling happens before this snapshot is built. SkillScanner.Scan rejects duplicates within one source, and ScanAndMerge uses a case-insensitive knownNames set to resolve cross-source collisions in native > server-feed > external order while recording DuplicateName issues. SkillInventoryRefresher only passes that accepted, already-deduplicated result into ReplaceAll; direct SkillRegistry.Register calls are test-only.
Issue #1552 is the remaining policy gap, though: the current precedence deliberately lets a native skill shadow a same-name server-feed skill. This PR preserves and centralizes that existing behavior; it does not claim to close #1552. The #1552 fix should reject/quarantine the native claim while source identity is still known (during create/scan/merge), rather than in Snapshot.Create, where origin/trust information is no longer available.
| var mergedResult = SkillScanner.ScanAndMerge(_paths.SkillsDirectory, _externalSources); | ||
| SkillRegistryUpdater.ApplyMergedScanResult( | ||
| _skillRegistry, _skillIndexLayer, mergedResult, _paths.SkillsDirectory, _externalSources); | ||
| var mergedResult = _inventoryRefresher.Refresh(); |
There was a problem hiding this comment.
this is a lot simpler than what we had before
There was a problem hiding this comment.
LGTM - align agents on using the skill loading tools instead of file lookups. Has the effect of virtualizing the indicies so the details around the file system become immaterial.
…0.25.0-alpha.onnx.6 (#1642) * fix: support Discord DM reminders (#1609) * Refactor ModelContextProtocol versioning in props file (#1614) Updated ModelContextProtocol package versions to use a variable for versioning. Signed-off-by: Aaron Stannard <[email protected]> * fix: serialize Slack processing status updates (#1556) Co-authored-by: Aaron Stannard <[email protected]> * ci: run required checks for merge queue groups (#1617) * Bump MessagePack from 3.1.7 to 3.1.8 (#1605) --- updated-dependencies: - dependency-name: MessagePack dependency-version: 3.1.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(cli): model set/picker preserve hand-set modalities on re-set (#1127) (#1610) * fix(cli): model set/picker preserve hand-set modalities on re-set (#1127) Re-selecting a model that is already configured wiped operator-set attributes on it. The write path rebuilt the Models[role] entry from scratch via ModelEntryWriter, which only writes modalities it was handed (a probe result). Modalities have no CLI input and can only be hand-edited, so a manual 'model set' (or a context-window tweak, or the TUI picker re-selecting the same model) passed null and silently deleted a hand-set InputModalities/OutputModalities — the concrete #1127 loss. Add ModelEntryWriter.WriteRole, a non-destructive persist: when the role already points at the same (provider, modelId), preserve the existing modalities and context window the caller did not supply; switching to a different model still starts clean (old attributes belonged to the old model). Routed 'model set' and the TUI model manager through it. Verified against the shipped binary: on stock beta 0.25.0, 'model set main <same-model> --context-window N' wipes InputModalities; with this fix the same command preserves it. No config-shape or schema change, so this is fully backwards compatible. Tests: WriteRole_SameModelWithoutModalities_PreservesHandSetModalities, WriteRole_DifferentModel_DropsPreviousModelModalities. * fix(cli): make model-set metadata operator-owned; discovery never clobbers it Hardens the non-destructive `model set`/picker rewrite (#1127) against every issue surfaced reviewing #1610, and closes the loop on modality overrides. ContextWindow and modalities are documented to "take precedence over provider-reported capability detection", so they are now treated as operator-owned overrides with a single precedence rule: explicit operator input > existing stored value > probe. A fresh probe seeds a first-time set or a model switch but never overwrites a value already on disk. Changes: 1. ContextWindow clamp preserved on same-model re-set. WriteRole takes the explicit --context-window and the probe default separately; the old callers collapsed them (`contextWindow ?? discovered`), so probe/picker paths always passed a non-null value and the operator's clamp was overwritten on every re-selection. 2. Modalities are no longer silently overwritten by discovery. Previously a probe that reported modalities replaced a stored override (the #1127 loss's twin); now the stored value wins, matching the field's "manual override bypasses detection" contract. 3. Operators can change/remove those overrides. Since discovery no longer edits them, add `--input-modalities`, `--output-modalities`, and `--clear-modalities` to `model set`. Explicit set replaces the stored value; clear removes it (runtime detection resolves). Supplying any of them (like --context-window) skips the probe as manual configuration. 4. Corrupt/legacy existing entry no longer aborts the command. ReadSameModelEntry guards the deserialize (catch JsonException): an unreadable entry (e.g. an unrecognized modality enum string) degrades to "nothing to preserve" and the command overwrites/repairs it. 5. No false-match on ModelReference defaults. Provider/ModelId default to the stock local-ollama model, so an entry omitting either key deserialized to that default and would false-match a re-set of the stock model; preservation now requires both keys. 6. Provenance not downgraded. A same-model re-set that did not re-resolve the ID (no probe → Manual) keeps a previously discovered origin (Live/Defaults); only a fresh discovery updates it. Tests: ModelEntryWriter unit coverage for each precedence path (clamp-over-probe, probe- does-not-override-existing-modalities, explicit set, clear-over-probe, first-time seeding, default-model false-match, corrupt-entry overwrite, provenance preserve/update) plus CLI end-to-end coverage for the new flags. Full CLI suite green; slopwatch clean; model-manager smoke tape passes. * fix(cli): harden model-set overrides + add --clear-context-window (#1610) Addresses code-review findings on the non-destructive model-set change: - probe gate: only --context-window short-circuits the probe; a modality flag no longer skips model-existence validation and context-window discovery - preservation read: a corrupt modality enum string no longer discards a valid operator-owned ContextWindow (field-tolerant recovery) - arg parsing: missing flag values and unknown args fail loudly instead of being silently dropped - cleared modality is now sticky: discovery is hands-off once a same-model entry exists, so a later probe cannot resurrect a --clear-modalities removal - TryParseModalities rejects raw numeric strings (named flags only) - provenance: preserve a prior discovered origin on any non-Live re-set (was only guarding Manual) - new --clear-context-window flag to force window re-detection (symmetry with --clear-modalities) Also hardens LoadModelSelection: a corrupt/legacy config no longer crashes `model set` (repairs it) or `model list` (reports it cleanly) or the TUI. Generalizes ModalityOverride into a shared ValueOverride<T> tri-state. Updates netclaw-operations skill (providers.md). Docs website tracked in netclaw-dev/netclaw-website#83. * feat(config): preserve model definitions across role switches * fix(config): validate named model role references * fix(cli): preserve models when editing providers * chore(deps): bump dotnet-sdk from 10.0.300 to 10.0.301 (#1381) Bumps [dotnet-sdk](https://github.com/dotnet/sdk) from 10.0.300 to 10.0.301. - [Release notes](https://github.com/dotnet/sdk/releases) - [Commits](dotnet/sdk@v10.0.300...v10.0.301) --- updated-dependencies: - dependency-name: dotnet-sdk dependency-version: 10.0.301 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(subagents): fail closed for unattended approvals (#1616) * Release 0.25.0-beta.3: update release notes and version metadata (#1618) * Add user-written `AGENTS.md` for application-specific agent guidelines (#1622) * Add deployment agent mission playbook * Keep identity routing in embedded guidance * Evaluate embedded identity routing * Prioritize specialized subagent guidance * test: skip SearXNG container test on Windows (#1625) * Use logical skill access and authoritative inventory refresh (#1634) * feat(skills): use logical skill access * docs(evals): restore README * test(skills): use root-preserving path joins * Preserve Git working context across sessions and subagents (#1630) * feat: preserve git context across subagents * fix: make subagent git context deterministic * test: make fixture path intent explicit * Stabilize config search screenshots (#1635) * Simplify STDIO MCP process ownership (#1636) * chore: bump Netclaw.SkillClient from 0.4.0-beta.4 to 0.4.0 stable (#1638) * fix(memory): stop curation dedup from overwriting existing documents (#1637) When a curation Create decision landed on an anchor that already had a document, both batch appliers reused the existing document_id, and the ON CONFLICT DO UPDATE overwrote that document's title, body, and classification with the new proposal. The old content was lost; there is no history table to recover it from. Now a Create collision appends the new content below a dated separator and keeps the existing title, boundary, audience, and sensitivity. If the incoming content is already present verbatim, the write is skipped. Consolidate decisions carry an explicit target document id, so they keep replacing near-duplicates as designed. Update decisions and no-collision inserts are unchanged. * Release 0.25.0-beta.4: update release notes and version metadata (#1640) --------- Signed-off-by: Aaron Stannard <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: petabridge-netclaw[bot] <289234546+petabridge-netclaw[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Summary
Validation
Behavioral evals
Spark endpoint with nvidia/Qwen3.6-27B-NVFP4:
Retained run IDs and artifacts are documented in evals/README.md.