fix(tui): auto-advance the add-skill-server flow on a successful probe#1458
Merged
Aaronontheweb merged 4 commits intoJun 22, 2026
Merged
Conversation
Adding a remote skill server made the operator press Enter twice on success: once to run the reachability probe, then again to dismiss "…Press Enter to continue." The original init wizard did not — a reachable feed went straight to the name step. This restores that behavior in the config editor. - On a successful probe, marshal the advance to the name step onto the loop thread via InvokeAsync (navigation is never safe from the off-loop probe continuation). A guarded continuation re-checks that the operator did not edit the URL/token or leave the add flow while the probe was in flight before navigating. - Failures keep their deliberate keypress: a 401 still pauses to let the operator add a bearer token, and an unreachable feed still requires an explicit "save anyway" — those are real decisions, not a reachable happy path. - Carry the probe's reachable line (e.g. "Skill feed reachable — 53 skills advertised.") onto the name screen, the way the wizard shows "Found N skills", so the confirmation is not lost to the auto-advance. Tests cover the auto-advance for both the direct-success and auth→token→success paths; the existing unreachable test proves a failure still does not auto-advance.
Aaronontheweb
enabled auto-merge (squash)
June 22, 2026 18:21
The probe confirmation carried onto the name screen ("Skill feed reachable — N
skills advertised.") rendered in the default white header. Color it green to match
how the init wizard and other config surfaces mark success, but only when the
carried message is an actual success — a save-anyway failure also lands on this
screen and must not read as green.
Aaronontheweb
disabled auto-merge
June 22, 2026 19:42
Aaronontheweb
enabled auto-merge (squash)
June 22, 2026 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a remote skill server made the operator press Enter twice on success: once to run the reachability probe, then again to dismiss "…Press Enter to continue." The original init wizard didn't — a reachable feed went straight to the name step (it showed "✓ Connected… Found N skills" above the name field). This restores that behavior in the config editor.
InvokeAsync(the Config TUI: marshal background label-refresh / save-reload state mutations back onto the Termina loop #1426 primitive). A guarded continuation re-checks that the operator didn't edit the URL/token or leave the add flow while the probe was in flight before navigating.Follow-up to #1452 (advertised skill count), addressing UX feedback that the success path shouldn't require a confirming keypress.
Validation
Netclaw.Cli.Tests: 1114/1114, including a new test that a reachable server auto-advances with a single Enter, and coverage that theauth → token → successpath also auto-advances. The existing unreachable test proves a failure still does not auto-advance.dotnet slopwatch analyze: no new violations · copyright headers ✓ghcr.io/netclaw-dev/skillserver(a netclaw image built from this branch).Smoke note
No native smoke tape: the add-skill-server prompt flow has no Skill Sources tape (none exists, and standing up a skill server inside a tape is net-new harness work). The flow is covered by the ViewModel tests above and verified end-to-end against the real skillserver image.