Skip to content

refactor(sessions): extract subscriber manager#1455

Merged
Aaronontheweb merged 2 commits into
netclaw-dev:devfrom
Aaronontheweb:feature/session-actor-subscriber-manager
Jun 22, 2026
Merged

refactor(sessions): extract subscriber manager#1455
Aaronontheweb merged 2 commits into
netclaw-dev:devfrom
Aaronontheweb:feature/session-actor-subscriber-manager

Conversation

@Aaronontheweb

Copy link
Copy Markdown
Collaborator

Summary

  • extract direct session subscriber state and filtered fan-out into SessionSubscriberManager
  • expose session phase transition legality through a focused helper and align Passivating transitions with the spec
  • add focused tests for subscriber filtering/snapshots and phase transition rules

Validation

  • dotnet test src/Netclaw.Actors.Tests --filter "FullyQualifiedNameSessionPhaseTransitionTests|FullyQualifiedNameSessionSubscriberManagerTests"
  • dotnet test src/Netclaw.Actors.Tests --filter "FullyQualifiedName~LlmSessionIntegrationTests"
  • dotnet test src/Netclaw.Actors.Tests --filter "FullyQualifiedName~SubAgentSpawnIntegrationTests"
  • dotnet test
  • dotnet slopwatch analyze
  • pwsh ./scripts/Add-FileHeaders.ps1 -Verify
  • git diff --check

@Aaronontheweb Aaronontheweb added the cleanup Code quality improvements and tech debt reduction label Jun 19, 2026

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified some of the LlmSessionActor code - working on trying to extract so many different state management fields from it.

@Aaronontheweb
Aaronontheweb enabled auto-merge (squash) June 19, 2026 20:16
@Aaronontheweb
Aaronontheweb merged commit ef15c07 into netclaw-dev:dev Jun 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code quality improvements and tech debt reduction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant