fix(tui): add Done rows to the Security & Access menu and editors#1448
Merged
Aaronontheweb merged 1 commit intoJun 19, 2026
Merged
Conversation
Discoverable back-out rows across the Security & Access surfaces, matching the adapter menu (netclaw-dev#1441) and Skill Sources pattern so operators don't have to know Esc: - Security & Access menu: add a "Done — Return to Settings Areas." row that backs out to the config dashboard via GoBack(). The config-editor coverage audit is updated to treat it as a navigation row, not a leaf editor needing coverage. - The four editor sub-screens (Posture, Enabled Features, Audience list, Audience profile): append a "Done" row after the real items. Each screen's navigation extends one past its item array, and the per-action methods (apply posture, toggle feature, open profile, activate/cycle profile row) guard the Done index to back out via GoBack() instead of indexing out of bounds. The audience-profile per-row help is also guarded for the Done row.
Aaronontheweb
enabled auto-merge (squash)
June 19, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discoverable "Done" back-out rows across the Security & Access surfaces, matching the adapter menu (#1441) and Skill Sources pattern so operators don't have to discover
Esc.Done — Return to Settings Areas.row backs out to the config dashboard viaGoBack(). The config-editor coverage audit is updated to treat it as a navigation row, not a leaf editor needing test coverage.Donerow is appended after the real items. Each screen's navigation extends one index past its item array, and every per-action method (apply posture, toggle feature, open profile, activate/cycle profile row) guards the Done index to back out viaGoBack()instead of indexing out of bounds. The audience-profile per-row help is guarded for the Done row too.Validation
Netclaw.Cli.Tests: 1102/1102 (5 new routing tests — the menu Done row + one per sub-screen)dotnet slopwatch analyze: no new violationsconfig-posture,config-features,config-audiencetapes ✓ (the three changed editors)Second batch of the config-TUI consistency pass (after #1441's adapter-menu Done row + footer/spacer fixes).