fix(tui): config-screen consistency — Done row, embedded footer, Search spacer#1441
Merged
Aaronontheweb merged 2 commits intoJun 19, 2026
Merged
Conversation
…ch spacer
Three small, independent consistency fixes to the config TUI:
- Channels adapter menu: add a discoverable "Done — Return to Channels." row to
the Slack/Discord/Mattermost management menu, matching the existing pattern on
Skill Sources and the channel-permissions screen. It routes to the adapter
picker, the same place Esc already goes ("[Esc] Channels"), so backing out no
longer requires knowing the Esc shortcut.
- Provider/Model managers: the top-level list footer hard-coded "[Esc] Quit",
but when embedded in `netclaw config` Esc actually navigates back to the
dashboard (Navigate("/config")), not quit. Make the footer conditional on
IsEmbeddedInConfig: "[Esc] Back" when embedded, "[Esc] Quit" only standalone.
- SearchConfigEditorPage: add the Layouts.Empty().Fill() spacer that every other
config page already has, so the status/keybind bars pin to the bottom on short
screens instead of floating up under the content.
Aaronontheweb
enabled auto-merge (squash)
June 19, 2026 02:32
Aaronontheweb
added a commit
that referenced
this pull request
Jun 19, 2026
) Discoverable back-out rows across the Security & Access surfaces, matching the adapter menu (#1441) and Skill Sources pattern so operators don't have to know Esc: - Security & Access menu: add a "Done — Return to Settings Areas." row that backs out to the config dashboard via GoBack(). The config-editor coverage audit is updated to treat it as a navigation row, not a leaf editor needing coverage. - The four editor sub-screens (Posture, Enabled Features, Audience list, Audience profile): append a "Done" row after the real items. Each screen's navigation extends one past its item array, and the per-action methods (apply posture, toggle feature, open profile, activate/cycle profile row) guard the Done index to back out via GoBack() instead of indexing out of bounds. The audience-profile per-row help is also guarded for the Done row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small, independent consistency fixes to the
netclaw configTUI, surfaced by a UI audit:Done — Return to Channels.row to the Slack/Discord/Mattermost management menu, which previously only backed out viaEsc. Matches the existing pattern on Skill Sources and the channel-permissions screen; routes to the adapter picker — the same place[Esc] Channelsalready goes.[Esc] Quit, but when embedded innetclaw configEsc actually navigates back to the dashboard (Navigate("/config")). Now conditional onIsEmbeddedInConfig:[Esc] Backwhen embedded,[Esc] Quitonly standalone.SearchConfigEditorPagefill spacer. Added theLayouts.Empty().Fill()spacer that all 8 other config pages already have, so the status/keybind bars pin to the bottom on short screens instead of floating up under the content.Validation
Netclaw.Cli.Tests: 1097/1097 (incl. a new test for the adapter-menu Done row)dotnet slopwatch analyze: no new violationsconfig-channelssmoke tape ✓ (drives the real adapter menu)Audit-driven consistency fixes; first batch of a broader config-TUI consistency pass (Done/Back rows on the Security & Access screens to follow).