fix: raise ValueError for unsupported __in lookup#145
Closed
llamafilm wants to merge 1 commit into
Closed
Conversation
abubnalitic-nbl
added a commit
to puneetdixit200/netbox-mcp-server
that referenced
this pull request
May 26, 2026
…t so id__in, status__in, etc. are also rejected (empirically silently ignored by NetBox), and surface the working list-as-value form in the error message. Keep PR netboxlabs#144's tool-description warning and tests.
abubnalitic-nbl
added a commit
that referenced
this pull request
May 26, 2026
* docs: clarify NetBox lookup filter support Signed-off-by: Puneet Dixit <[email protected]> * fix(filters): reject relationship id list lookups Github-Issue: #79 Signed-off-by: Puneet Dixit <[email protected]> * Pull in PR #145's key changes: drop the _id suffix carve-out so id__in, status__in, etc. are also rejected (empirically silently ignored by NetBox), and surface the working list-as-value form in the error message. Keep PR #144's tool-description warning and tests. --------- Signed-off-by: Puneet Dixit <[email protected]> Co-authored-by: Puneet Dixit <[email protected]> Co-authored-by: Anton Bubna-Litic <[email protected]>
Contributor
|
Thanks @llamafilm - I've folded your improvements into #144 (commit). This should be in now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
This could use more testing but it seems to work for me