fix: reject __in lookups, suggest list-as-value form#144
Merged
abubnalitic-nbl merged 3 commits intoMay 26, 2026
Conversation
Signed-off-by: Puneet Dixit <[email protected]>
Github-Issue: netboxlabs#79 Signed-off-by: Puneet Dixit <[email protected]>
puneetdixit200
changed the title
Contributor
Author
|
Updated this beyond the original wording-only guard. The branch now rejects relationship ID list filters such as Verification passed locally: |
…t so id__in, status__in, etc. are also rejected (empirically silently ignored by NetBox), and surface the working list-as-value form in the error message. Keep PR netboxlabs#144's tool-description warning and tests.
Contributor
|
Thanks for this @puneetdixit200 , I've included some of the improvements from #145 as well for a more complete handling of the |
abubnalitic-nbl
changed the title
abubnalitic-nbl
approved these changes
May 26, 2026
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vminterface_id__inbefore calling NetBox, because unsupported lookups may be silently ignored and return overly broad resultsid__invalidnetbox_get_objectstool description so MCP clients see the runtime ruleCloses #79. Supersedes #145, credit to @llamafilm for the broader-scope insight and the actionable error message.
Verification
uv run pytest tests/test_filter_validation.py -quv run pytest tests/test_tool_descriptions.py -quv run pytest tests/test_filter_validation.py tests/test_tool_descriptions.py -quv run pytest -quv run ruff checkgit diff --checkAI disclosure
This contribution was prepared with AI assistance and reviewed before submission.