Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile with new versions #456

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Update Dockerfile with new versions #456

merged 3 commits into from
Jul 19, 2024

Conversation

c-vandendyck-kbr
Copy link
Contributor

Update ENV:

  • solrwayback 5.1
  • tomcat 9
  • solr 9

Also update RUN commands in order to call the good folder and the -c option

@thomasegense
Copy link
Contributor

Thanks. I will look into it tomorrow!

@c-vandendyck-kbr
Copy link
Contributor Author

Hi @thomasegense !

And sorry it took me so much time ;-)

@VictorHarbo VictorHarbo self-requested a review July 19, 2024 08:19
VictorHarbo
VictorHarbo requested changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@VictorHarbo VictorHarbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed working as it should. Thanks a lot! The Docker file contains documentation on how to start the service in the lines 1-22. I would like the following changes here:

  • Could you please update exports in line 10-12 to match the ENV set in the file.
  • In line 13 add -c to the command.
  • in line 14 change apache-tomcat to tomcat, as thats the name of the directory now.

@VictorHarbo
Copy link
Collaborator

Ps. I've tested the Dockerfile on a Macbook running an M1 processor and it works flawlessly.

@thomasegense
Copy link
Contributor

@VictorHarbo When you accept the PR, also close this Jira: #439

@c-vandendyck-kbr
Copy link
Contributor Author

Hi @VictorHarbo !

Thanks for your feedback!
In fact, in the excitement of this first pull-request for the solrwayback project, I completely forgot about the documentation.
My mistake !

I've just corrected it ;-)

VictorHarbo
VictorHarbo requested changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@VictorHarbo VictorHarbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single change and then it is good to go :)

@VictorHarbo
Copy link
Collaborator

Hi @VictorHarbo !

Thanks for your feedback! In fact, in the excitement of this first pull-request for the solrwayback project, I completely forgot about the documentation. My mistake !

I've just corrected it ;-)

No worries. We love to have excited people contributing! One minor change and I'll merge it.

VictorHarbo
VictorHarbo approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@VictorHarbo VictorHarbo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @c-vandendyck-kbr. Everything looks good now. Congratulations on your first contribution to SolrWayback! 🎆

@VictorHarbo VictorHarbo merged commit 9bd0461 into netarchivesuite:master Jul 19, 2024
@VictorHarbo VictorHarbo mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorHarbo VictorHarbo VictorHarbo approved these changes

Assignees

@c-vandendyck-kbr c-vandendyck-kbr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-vandendyck-kbr @thomasegense @VictorHarbo