Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL + click on facet to open in new tab #406

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

jesperlauridsen
Copy link
Collaborator

Added the feature, while keeping the normal interaction without CTRL.

closes #404

@jesperlauridsen jesperlauridsen requested a review from jorntx August 11, 2023 11:08
Copy link
Collaborator

@jorntx jorntx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution, tested but failed on Apple devices so I have proposed a fix for this.

Besides that only minor comments and some praise.

removed console.log
small refactorings (laters, ===).
@jesperlauridsen jesperlauridsen requested a review from jorntx August 11, 2023 19:57
Copy link
Collaborator

@jorntx jorntx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jorntx jorntx merged commit 792f767 into master Aug 14, 2023
@jorntx jorntx deleted the 404_ctrl-click-open-new-window-on-facets branch August 14, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants