Zip export. #390
Merged
Zip export. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| zos.close(); | ||
| output.close(); | ||
| log.info("Streamed {} warc entries with the contentType: '{}'.", streamedDocs, normalizedContentType); |
There was a problem hiding this comment.
This is a useful, maybe add that was 'zip import' and it has completed successfully.
| * @param warcMetadata contains the timestamp, id, originalUrl and file extension, which is used to create the filename. | ||
| * @return a string in the format timestamp_id_originalUrlStrippedForNonASCIIChars.extension. | ||
| */ | ||
| private String createFilename(String contentType, WarcMetadataFromSolr warcMetadata) { |
There was a problem hiding this comment.
For the file name, implement:
-
Only keep alphanumeric part of URLs. Still use '_' seperator.
-
Filename total length must not exceed 255 characters since this is the limit in Windows.
-
Collapse multiple consecutive'_' into 1.
| * @param contentType string to normalize. | ||
| * @return normalized contentType string. | ||
| */ | ||
| private String normalizeContentType(String contentType) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extraction of content from WARC files by mimetype
Closes #382 and #245