Skip to content

Tidy test scripts#1471

Merged
jokob-sk merged 2 commits intonetalertx:mainfrom
adamoutler:tidy-test-scripts
Jan 29, 2026
Merged

Tidy test scripts#1471
jokob-sk merged 2 commits intonetalertx:mainfrom
adamoutler:tidy-test-scripts

Conversation

@adamoutler
Copy link
Member

@adamoutler adamoutler commented Jan 29, 2026 •
edited by coderabbitai bot
Loading

When using agents to generate tests, they tend to annotate tests docker_tests. I believe this is because of the naming convention and location of the github test script. The intent of this PR is to improve clarity of test script names.

  • move main test script from /tests/docker_tests to /scripts
  • rename from run_docker_tests to run_tests_in_docker_environment

Summary by CodeRabbit

  • Chores
    • Reorganized internal test automation scripts and updated workflow configurations for improved project structure.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request consolidates test infrastructure by removing the devcontainer-based test script and redirecting CI/CD workflows to use a centralized Docker-based test runner script located in the scripts directory.

Changes

Cohort / File(s) Summary
Development Container Removal
.devcontainer/scripts/run-tests.sh		 Removed entire shell script including shebang, pytest invocation with options (-q --maxfail=1 --disable-warnings), PYTHONPATH configuration, and workspace directory setup.
CI/CD Workflow Updates
.github/workflows/code-checks.yml, .github/workflows/run-all-tests.yml		 Updated docker test script references from test/docker_tests/run_docker_tests.sh to scripts/run_tests_in_docker_environment.sh in chmod, sed, and execution commands.
Test Script Metadata
scripts/run_tests_in_docker_environment.sh		 Updated header comment to reflect renamed script name from run_docker_tests.sh to run_tests_in_docker_environment.sh.

Possibly related PRs

  • netalertx/NetAlertX#1299: Related to docker-based test runner consolidation and CI workflow updates to use centralized test execution scripts.

Poem

🐰 Scripts once scattered, now consolidated bright,
Docker test runner guides the CI light,
Devcontainer's path no longer needed here,
Centralized testing—the workflow's clearer! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Tidy test scripts' is vague and overly generic, using non-descriptive language that doesn't convey the specific organizational changes made to the codebase. Consider using a more descriptive title like 'Reorganize test scripts: move to scripts/ and rename for clarity' to better communicate the structural changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@jokob-sk jokob-sk merged commit 52ac9fc into netalertx:main Jan 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamoutler @jokob-sk