Skip to content

Remove dev branch from docker compose file#1333

Merged
jokob-sk merged 1 commit intonetalertx:mainfrom
KihtrakRaknas:patch-2
Dec 7, 2025
Merged

Remove dev branch from docker compose file#1333
jokob-sk merged 1 commit intonetalertx:mainfrom
KihtrakRaknas:patch-2

Conversation

@KihtrakRaknas
Copy link
Contributor

@KihtrakRaknas KihtrakRaknas commented Dec 7, 2025 •
edited by coderabbitai bot
Loading

It is easy to miss that this is the dev image when copying the docker compose file.

Summary by CodeRabbit

  • Documentation
    • Updated Docker Compose configuration to reference the production image instead of the development image.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025 •
edited
Loading

Walkthrough

Updated the Docker image reference in the Docker Compose configuration from the development tag to the production tag for the netalertx service. This is a straightforward configuration change reflecting a shift from dev to production builds.

Changes

Cohort / File(s) Summary
Docker Configuration
docs/DOCKER_COMPOSE.md		 Updated netalertx service Docker image reference from ghcr.io/jokob-sk/netalertx-dev:latest to ghcr.io/jokob-sk/netalertx:latest

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file with a straightforward image tag update
  • No logic, dependencies, or behavioral changes
  • Configuration-only modification

Poem

🐰 From dev to prod, the rabbit hops with glee,
A simple tag swap, as smooth as can be!
The netalertx now wears its finest attire,
Production-ready, reaching ever higher! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the Docker Compose file to remove the dev branch reference (changing from netalertx-dev:latest to netalertx:latest).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ee9064 and c6de724.

📒 Files selected for processing (1)
  • docs/DOCKER_COMPOSE.md (1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings 
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:18-19
Timestamp: 2025-09-20T03:01:19.912Z
Learning: In the NetAlertX repository, .devcontainer/Dockerfile is auto-generated and should not be reviewed directly. Review comments about dependencies and build steps should be directed at the root Dockerfile where the actual source commands are located.

Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/devcontainer.json:5-8
Timestamp: 2025-09-20T02:56:24.501Z
Learning: In the NetAlertX devcontainer setup, the final .devcontainer/Dockerfile is generated by combining the root Dockerfile with .devcontainer/resources/devcontainer-Dockerfile using the generate-dockerfile.sh script. The devcontainer.json should reference the generated file, not the root Dockerfile.

Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1230
File: .devcontainer/resources/devcontainer-overlay/services/config/nginx/netalertx.conf.template:1-2
Timestamp: 2025-10-19T01:40:57.095Z
Learning: In the NetAlertX repository, .devcontainer/resources/devcontainer-overlay/services/config/nginx/netalertx.conf.template is an auto-generated file that is intentionally committed to source control. It cannot be regenerated automatically outside the devcontainer environment and is required for the devcontainer to start, creating a bootstrap dependency.
📚 Learning: 2025-09-20T03:01:19.912Z 
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:18-19
Timestamp: 2025-09-20T03:01:19.912Z
Learning: In the NetAlertX repository, .devcontainer/Dockerfile is auto-generated and should not be reviewed directly. Review comments about dependencies and build steps should be directed at the root Dockerfile where the actual source commands are located.

Applied to files:

  • docs/DOCKER_COMPOSE.md
📚 Learning: 2025-09-20T02:56:24.501Z 
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/devcontainer.json:5-8
Timestamp: 2025-09-20T02:56:24.501Z
Learning: In the NetAlertX devcontainer setup, the final .devcontainer/Dockerfile is generated by combining the root Dockerfile with .devcontainer/resources/devcontainer-Dockerfile using the generate-dockerfile.sh script. The devcontainer.json should reference the generated file, not the root Dockerfile.

Applied to files:

  • docs/DOCKER_COMPOSE.md
📚 Learning: 2025-10-19T01:40:57.095Z 
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1230
File: .devcontainer/resources/devcontainer-overlay/services/config/nginx/netalertx.conf.template:1-2
Timestamp: 2025-10-19T01:40:57.095Z
Learning: In the NetAlertX repository, .devcontainer/resources/devcontainer-overlay/services/config/nginx/netalertx.conf.template is an auto-generated file that is intentionally committed to source control. It cannot be regenerated automatically outside the devcontainer environment and is required for the devcontainer to start, creating a bootstrap dependency.

Applied to files:

  • docs/DOCKER_COMPOSE.md
📚 Learning: 2025-09-20T14:09:29.159Z 
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/setup.sh:103-116
Timestamp: 2025-09-20T14:09:29.159Z
Learning: In NetAlertX devcontainer setup, the netalertx user has write permissions to /var/log/nginx/ directory as it's explicitly chowned to netalertx:www-data in the Dockerfile, so setup.sh can write to nginx log files without sudo.

Applied to files:

  • docs/DOCKER_COMPOSE.md
📚 Learning: 2025-10-26T17:09:18.621Z 
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: .devcontainer/scripts/setup.sh:146-148
Timestamp: 2025-10-26T17:09:18.621Z
Learning: In `.devcontainer/scripts/setup.sh` and other devcontainer setup scripts for NetAlertX, chmod 666 on /var/run/docker.sock is acceptable because devcontainer environments are single-user development contexts where convenience can take priority over strict permission hardening.

Applied to files:

  • docs/DOCKER_COMPOSE.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: docker_dev
🔇 Additional comments (1)
docs/DOCKER_COMPOSE.md (1)

20-20: Good catch—prevents accidental dev deployments.

Changing the baseline image from the dev variant to the production image is a sensible default. This reduces the friction and likelihood that users will accidentally deploy the dev image when copying the configuration as a starting point.

To ensure completeness, please confirm whether any other Docker Compose files in the repository (e.g., actual docker-compose.yaml or docker-compose.yml files outside the docs folder) also reference the old dev image and should be updated as part of this change.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jokob-sk jokob-sk merged commit cd1ce2a into netalertx:main Dec 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KihtrakRaknas @jokob-sk