install/ubuntu/install.ubuntu.sh (2)

85-86: Invoke start script via bash to avoid execute-bit surprises

-"$INSTALL_DIR/install/ubuntu/start.ubuntu.sh"
+bash "$INSTALL_DIR/install/ubuntu/start.ubuntu.sh"

---

1-2: Fail fast

 #!/usr/bin/env bash
+
+set -Eeuo pipefail

install/ubuntu/start.ubuntu.sh (1)

213-214: Show the effective port in the banner

-echo "[INSTALL] 🚀 Starting app - navigate to your <server IP>:${PORT}"
+echo "[INSTALL] 🚀 Starting app - navigate to your <server IP>:${PORT:-20211}"

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

install/ubuntu/install.ubuntu.sh (1)

49-60: Make “wipe and re-clone” safe; fix SC2115 and remove hard-coded /app in pkill
Current block risks destructive rm -rf and misses installs not in /app.

-  if [ "$confirmation" == "install" ]; then
-    if [ -n "$INSTALL_DIR" ] && [ "$INSTALL_DIR" != "" ]; then
-      echo "Removing existing installation..."
-      service nginx stop 2>/dev/null
-      pkill -f "python /app/server" 2>/dev/null
-      umount  "$INSTALL_DIR/api" 2>/dev/null
-      umount  "$INSTALL_DIR/front" 2>/dev/null
-      rm -rf "$INSTALL_DIR/"
-      git clone https://github.com/jokob-sk/NetAlertX "$INSTALL_DIR/"
-    else
-      echo "INSTALL_DIR is not set or is root. Aborting for safety."
-      exit 1
-    fi
+  if [ "$confirmation" == "install" ]; then
+    # Safety checks
+    if [ -z "${INSTALL_DIR:-}" ] || [ "$INSTALL_DIR" = "/" ] || [ "$INSTALL_DIR" = "." ]; then
+      echo "Invalid or unsafe INSTALL_DIR='$INSTALL_DIR'. Aborting."
+      exit 1
+    fi
+    echo "Removing existing installation..."
+    service nginx stop 2>/dev/null || true
+    pkill -f "python ${INSTALL_DIR}/server" 2>/dev/null || true
+    if command -v mountpoint >/dev/null 2>&1; then
+      mountpoint -q "$INSTALL_DIR/api"   && umount "$INSTALL_DIR/api"   || true
+      mountpoint -q "$INSTALL_DIR/front" && umount "$INSTALL_DIR/front" || true
+    else
+      umount "$INSTALL_DIR/api" 2>/dev/null || true
+      umount "$INSTALL_DIR/front" 2>/dev/null || true
+    fi
+    rm -rf -- "${INSTALL_DIR:?}/"
+    git clone https://github.com/jokob-sk/NetAlertX "$INSTALL_DIR/"

install/ubuntu/install.ubuntu.sh (6)

1-2: Enable strict mode for safer installs
Use bash strict mode to fail fast on errors and undefined vars.

 #!/usr/bin/env bash
 
+set -euo pipefail
+IFS=$'\n\t'

---

15-17: Make INSTALL_DIR configurable (honor env override)
Avoid hard-coding; allow users/CI to set INSTALL_DIR.

-# Set environment variables
-INSTALL_DIR=/app  # Specify the installation directory here
+# Set environment variables
+# Allow override via environment: e.g. `INSTALL_DIR=/opt/netalertx sudo -E ./install.ubuntu.sh`
+INSTALL_DIR="${INSTALL_DIR:-/app}"  # Default install dir

---

25-33: Run apt in noninteractive mode to avoid prompts
Prevents hangs on TTY-less runs and speeds up installs.

 echo "Updating packages"
 echo "-----------------"
-apt-get update
+export DEBIAN_FRONTEND=noninteractive
+apt-get update -y
 echo "Making sure sudo is installed"
-apt-get install sudo -y
+apt-get install -y sudo
 
 # Install Git
 echo "Installing Git"
-apt-get install -y git
+apt-get install -y git

---

62-66: Consistency: tolerate missing nginx and ensure cd failure doesn’t proceed
Minor robustness tweaks.

-    service nginx stop 2>/dev/null
-   pkill -f "python ${INSTALL_DIR}/server" 2>/dev/null
-    cd "$INSTALL_DIR" || { echo "Failed to change directory to $INSTALL_DIR"; exit 1; }
+    service nginx stop 2>/dev/null || true
+    pkill -f "python ${INSTALL_DIR}/server" 2>/dev/null || true
+    cd "$INSTALL_DIR" || { echo "Failed to change directory to $INSTALL_DIR"; exit 1; }

---

85-86: Optionally replace shell with start script
Not required, but exec avoids an extra shell process.

-"$INSTALL_DIR/install/ubuntu/start.ubuntu.sh"
+exec "$INSTALL_DIR/install/ubuntu/start.ubuntu.sh"

---

51-55: Refine shell commands and address ShellCheck warnings

• Change read -p "Enter your choice: " confirmation to
  read -r -p "Enter your choice: " confirmation
  to preserve backslashes (SC2162).
• Update rm -rf "$INSTALL_DIR/" to
  rm -rf "${INSTALL_DIR:?}/"
  to guard against an empty INSTALL_DIR (SC2115).
• Optionally, wrap the nginx stop and unmounts in checks—e.g.:

  if systemctl is-active --quiet nginx; then
    systemctl stop nginx
  fi
  
  if mountpoint -q "$INSTALL_DIR/api"; then
    umount "$INSTALL_DIR/api"
  fi

  to reduce noise when errors are already redirected to /dev/null.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

install/ubuntu/install.ubuntu.sh (7)

1-2: Harden script execution.

Enable strict mode for safer failures.

 #!/usr/bin/env bash
-
+set -euo pipefail
+IFS=$'\n\t'

---

16-16: Allow INSTALL_DIR override via env.

Keep default /app but let users change it without editing the file.

-INSTALL_DIR=/app  # Specify the installation directory here
+: "${INSTALL_DIR:=/app}"  # Default install directory; override via env

---

53-58: Simplify nginx stop logic and ignore benign failures.

Current list-units grep can mislead; just try stopping with fallback.

-      # Stop nginx if running
-      if command -v systemctl >/dev/null 2>&1 && systemctl list-units --type=service | grep -q nginx; then
-      systemctl stop nginx 2>/dev/null
-      elif command -v service >/dev/null 2>&1; then
-      service nginx stop 2>/dev/null
-      fi
+      # Stop nginx if available (ignore if not installed)
+      if command -v systemctl >/dev/null 2>&1; then
+        systemctl stop nginx 2>/dev/null || true
+      elif command -v service >/dev/null 2>&1; then
+        service nginx stop 2>/dev/null || true
+      fi

---

61-61: Tighten process termination.

Use a consistent, defensive pattern; add -- and a broader match to cover both spaces and args.

-      pkill -f "python.*${INSTALL_DIR}/server" 2>/dev/null
+      pkill -f -- "python.*${INSTALL_DIR}/server" 2>/dev/null
@@
-   pkill -f "python ${INSTALL_DIR}/server" 2>/dev/null
+    pkill -f -- "python.*${INSTALL_DIR}/server" 2>/dev/null

Also applies to: 83-83

---

105-105: Invoke start script via bash to avoid exec-bit pitfalls.

Prevents failures if the file isn’t executable.

-"$INSTALL_DIR/install/ubuntu/start.ubuntu.sh"
+bash "$INSTALL_DIR/install/ubuntu/start.ubuntu.sh"

---

28-30: Installing sudo while already root is unnecessary.

Harmless but can be skipped to speed up runs.

-echo "Making sure sudo is installed"
-apt-get install sudo -y
+# sudo is not needed when running as root; skip install to save time
+# apt-get install -y sudo

---

35-47: Non-interactive option hint.

Consider a non-interactive mode (e.g., CONFIRMATION env/cmd flag) for automation.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro