Sanitize hostnames, macs, and vendor names before running .lower/.upper on them to prevent AttributeError#1098
Conversation
Fixes netalertx#1088 by sanitizing the inputs to mac, vendor, and name before running .upper/.lower to ensure they are type STR to avoid AttributeError
|
Cheers @slammingprogramming 🙏🙂 |
|
Hey @slammingprogramming 👋 do you think your changes to |
|
@jokob-sk the ones i have submitted should be fine, that other original one we reverted I don't recommend, only because I haven't confirmed all changes are stable. this one is stable, though. simple fix for the string sanitization is all. it's been working reliably for me with this fix injected into my docker of netalertx (the stable release docker) i have not yet tested it working under all changes in the netalertx-dev docker, so I'd recommend we make sure it works with all changes made there. But it's probably fine. |
|
Thanks! Feel free to open a new PR once you are happy and I have a look 🙂 |
2 participants
Fixes #1088 by sanitizing the inputs to mac, vendor, and name before running .upper/.lower to ensure they are type STR to avoid AttributeError
Closes #1088