fix(start): wait for async shutdown hooks before exiting#3313
Merged
kamilmysliwiec merged 1 commit intoApr 7, 2026
Merged
Conversation
Member
|
this PR introduced 2 regressions, reverting.. |
kamilmysliwiec
added a commit
that referenced
this pull request
Apr 15, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When running
nest start, pressing Ctrl+C (SIGINT) causes the parent CLI process to immediately kill the child NestJS application viatreeKillSync, without giving it time to execute async shutdown hooks (onModuleDestroy,onApplicationShutdown). This means graceful shutdown logic (closing DB connections, flushing logs, etc.) never runs.Issue Number: #3158
What is the new behavior?
The parent process now installs
SIGINTandSIGTERMhandlers that forward the signal to the child process viachildProcessRef.kill(signal)instead of killing it immediately. The parent stays alive until the child exits naturally, giving the NestJS application time to run its async shutdown lifecycle hooks before the process terminates.Does this PR introduce a breaking change?
Other information
Files changed:
actions/start.action.ts— Added signal forwarding handlers that sendSIGINT/SIGTERMto the child process instead of killing it immediatelytest/actions/start.action.spec.ts— Added 4 regression tests verifying signal forwarding behavior