Skip to content

fix(core): use module class to generate hash instead of name#3363

Merged
kamilmysliwiec merged 1 commit into6.10.0from
fix/equal-module-names
Nov 15, 2019
Merged

fix(core): use module class to generate hash instead of name#3363
kamilmysliwiec merged 1 commit into6.10.0from
fix/equal-module-names

Conversation

@kamilmysliwiec
Copy link
Copy Markdown
Member

@kamilmysliwiec kamilmysliwiec commented Nov 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3362

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec kamilmysliwiec mentioned this pull request Nov 8, 2019
Closed
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 8, 2019

Pull Request Test Coverage Report for Build 6775

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 95.315%
Totals Coverage Status
Change from base Build 6764: -0.001%
Covered Lines: 4394
Relevant Lines: 4610
💛 - Coveralls

@kamilmysliwiec kamilmysliwiec added this to the 6.10.0 milestone Nov 15, 2019
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.10.0 November 15, 2019 12:12
@kamilmysliwiec kamilmysliwiec merged commit a37c97f into 6.10.0 Nov 15, 2019
@delete-merged-branch delete-merged-branch Bot deleted the fix/equal-module-names branch November 15, 2019 12:12
@lock
Copy link
Copy Markdown

lock Bot commented Feb 13, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

scope: core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kamilmysliwiec @coveralls