Repository navigation
fix(common): invoke proto-key stripping hook via this in transform - #17761
Merged
kamilmysliwiec merged 1 commit intoSep 15, 2026
Merged
kamilmysliwiec merged 1 commit into
kamilmysliwiec merged 1 commit into
Conversation
ValidationPipe and StandardSchemaValidationPipe both expose a protected method meant to be overridden by subclasses to customize proto-key stripping, but transform() called the standalone helper function directly instead of going through the instance method, so a subclass override was silently never invoked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ValidationPipeandStandardSchemaValidationPipeboth expose aprotected stripProtoKeys(value)method that is clearly intended as an overridable extension point (existing "subclass compatibility" specs already callsuper.stripProtoKeys(...)from a subclass). However,transform()in both classes calls the standalonestripProtoKeys(value)helper function directly instead ofthis.stripProtoKeys(value).As a result, if a consumer subclasses either pipe and overrides
stripProtoKeys()(e.g. to customize prototype-pollution key stripping for their app), the override is silently never invoked at runtime —transform()always runs the base behavior instead.Issue Number: N/A
What is the new behavior?
Both
transform()methods now callthis.stripProtoKeys(value), so a subclass override is correctly invoked during validation. Added a regression test to each pipe's spec file asserting that an overriddenstripProtoKeysis actually called duringtransform().Does this PR introduce a breaking change?
Other information
Verified: full
packages/commontest suite (751 tests) passes, andoxlintis clean on the changed files.