fix: rabbitmq bindings and auto-generated queues#14129
Merged
kamilmysliwiec merged 1 commit intonestjs:11.0.0from Nov 18, 2024
Merged
fix: rabbitmq bindings and auto-generated queues#14129kamilmysliwiec merged 1 commit intonestjs:11.0.0from
kamilmysliwiec merged 1 commit intonestjs:11.0.0from
Conversation
Pull Request Test Coverage Report for Build b6c85c24-7c65-4e65-a253-40dfa5c0e6b8Details
💛 - Coveralls |
eljabriyassine
left a comment
eljabriyassine
left a comment
There was a problem hiding this comment.
yes that a good idea the check
1 task
kamilmysliwiec
added
effort3: weeks
type: bug 😭
scope: microservices
and removed
effort3: weeks
labels
Contributor
Author
|
@kamilmysliwiec |
12 tasks
|
Nice work @EeeasyCode! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, when creating a new microservice with @nestjs/microservices for RMQ, using an empty string for the queue name creates a queue named default rather than a unique, exclusive queue. Additionally, binding a queue to an exchange specified by exchange and routingKey does not occur as expected.
Issue Number: #13931
What is the new behavior?
This PR modifies the default queue name behavior to use an auto-generated name when an empty string is provided. It also implements automatic binding of the queue to the specified exchange and routing key, aligning with standard RabbitMQ behavior.
Does this PR introduce a breaking change?
Other information
This PR also includes updates to the microservices package documentation, detailing the new exchange and routingKey options and their behavior to ensure users have clear guidance on setting up RMQ queues and exchanges in alignment with RabbitMQ standards.