fix(common): type narrowing context parameter on createParamDecorator's callback #14126
Merged
kamilmysliwiec merged 2 commits intonestjs:11.0.0from Nov 12, 2024
Merged
fix(common): type narrowing context parameter on createParamDecorator's callback #14126kamilmysliwiec merged 2 commits intonestjs:11.0.0from
kamilmysliwiec merged 2 commits intonestjs:11.0.0from
Conversation
1 task
Pull Request Test Coverage Report for Build 7eb12452-b4ee-4030-b499-95a1c23491beDetails
💛 - Coveralls |
EeeasyCode
changed the title
micalevisk
suggested changes
Nov 10, 2024
| @@ -1,7 +1,9 @@ | |||
| import { ExecutionContext } from '..'; | |||
Member
There was a problem hiding this comment.
Can you please import this from the file instead of from the barrel file
Contributor
Author
There was a problem hiding this comment.
@micalevisk
Sure, I have just updated the code with the mentioned changes. Please check!
Thank you for the feedback.
Member
|
LGTM |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #14093
The context parameter in createParamDecorator callback currently has an any type, which reduces type safety. Developers are unable to leverage the type-checking benefits of TypeScript when working with this parameter.
What is the new behavior?
The context parameter in the createParamDecorator callback now has a narrower type of ExecutionContext. This allows developers to benefit from TypeScript’s type-checking capabilities, improving code quality and reducing potential errors when using this parameter in decorators.
Does this PR introduce a breaking change?
Other information
This change improves type safety and aligns with TypeScript best practices by eliminating unnecessary any types. Tests have been added to validate that the context parameter is indeed typed as ExecutionContext. Additional documentation has been updated to reflect this enhancement.