v0.51.16 — 3-PR batch (#1768, #1778, #1779)#1781
Merged
nesquena-hermes merged 7 commits intomasterfrom May 7, 2026
Merged
Conversation
Constituent PRs: - #1768 (@franksong2702) serialize Anthropic env fallback reads. Closes #1736. - #1778 (@Michaelyklam) preserve CLI session tool metadata. Closes #1772. - #1779 (@Michaelyklam) reset model picker on session switch. Closes #1771. AUTO-FIX: Opus stage-310 caught a regression in the new !hasSessionModel branch — it dropped the deferModelCorrection guard that the parallel else-branch keeps. Fired spurious /api/session/update POSTs against imported/read-only CLI sessions whose model field reads 'unknown' (the exact surface #1778 introduces in this same release). Wrapped the new branch's _persistSessionModelCorrection call + state mutation in if(!deferModelCorrection). Added test_sync_topbar_does_not_persist_correction_while_model_resolution_deferred regression test covering both empty and 'unknown' fast-path interaction. Tests: 4694 → 4702 collected (+8). 4695 passed, 4 skipped, 3 xpassed, 0 failed in 141.29s. Pre-release verification: - All 3 PRs CI-green individually. - node -c clean on static/ui.js. - 11/11 browser API endpoints PASS. - Pre-stamp re-fetch: all PR heads match local rebases. - Opus advisor: SHIP #1768 + #1778, #1779 SHOULD-FIX before merge — auto-fix applied at stage with regression test, re-verified clean. Closes #1736, #1771, #1772.
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.51.16 — 3-PR batch (anthropic env race close, CLI tool metadata, model picker reset)
Constituent PRs
_clear_anthropic_env_values()+ runtime-provider resolver behind_ENV_LOCK(same lock already serializing env save/restore in streaming.py — no new lock, no ordering risk). Opus stage-310 verified lock placement and re-entrancy clean.tool_calls,tool_results,reasoning_details,codex_reasoning_items,codex_message_items,reasoning_content,reasoningfromstate.db.messages(PRAGMA-guarded for legacy schemas). Passive enrichment usessave(touch_updated_at=False).!hasSessionModelbranch dropping thedeferModelCorrectionguard, which would have fired spurious/api/session/updatePOSTs against the exact surface fix: preserve CLI session tool metadata #1778 introduces in this same release (CLI sessions withmodel: "unknown"). Wrapped persist call inif(!deferModelCorrection)+ added regression test.Tests
4694 → 4702 collected (+8). 4695 passed, 0 failed.
Pre-release verification
api/routes.py(fix(oauth): serialize Anthropic env fallback reads #1768 + fix: preserve CLI session tool metadata #1778) auto-merged — different functions (oauth env-lock helpers vs CLI session loader extension).Closes