fix: simplify compact activity summaries#1725
fix: simplify compact activity summaries#1725Michaelyklam wants to merge 2 commits intonesquena:masterfrom
Conversation
SummaryPulled the branch and walked the diff. The change is a clean visual simplification of the compact Activity row: drop the redundant tool-name list and trailing count badge, keep just Code referenceReading group.innerHTML=`<button type="button" class="tool-call-group-summary" aria-expanded="${collapsed?'false':'true'}" onclick="..."><span class="tool-call-group-chevron">${li('chevron-right',12)}</span><span class="tool-call-group-label">Activity</span><span class="tool-call-group-duration"></span></button><div class="tool-call-group-body"></div>`;vs origin/master which still has The matching const cards=Array.from(group.querySelectorAll('.tool-card-row .tool-card'));
const toolCount=cards.length;
const label=group.querySelector('.tool-call-group-label');
const durationEl=group.querySelector('.tool-call-group-duration');
if(label){
if(toolCount) label.textContent=`Activity: ${toolCount} tool${toolCount===1?'':'s'}`;
else label.textContent='Activity';
}That drops the DiagnosisThe DESIGN.md edit at
That language explicitly forbids each of the three things removed. The two static regression tests in The CSS removals in Coordination with #1729
I left the same coordination note on #1729. The two changes are conceptually independent (visual cleanup vs. UI-state durability), so neither should block the other — just needs a quick reconciliation pass on whichever rebases. VerificationCI is green on 3.11/3.12/3.13 at commit |
|
Thanks @Michaelyklam — this shipped in v0.51.8 (commit GitHub didn't auto-close because the merge commit only references the squash-merged stage branch, not your fork's commit directly — closing manually for hygiene. Live now on https://get-hermes.ai/ and on existing installs after Release notes: https://github.com/nesquena/hermes-webui/releases/tag/v0.51.8 |
…p + test-isolation fix Constituent PRs: - nesquena#1725 (@Michaelyklam) — simplify compact Activity row summary - nesquena#1726 (@Michaelyklam) — delegate generic provider catalogs to Hermes CLI (slice of nesquena#1240) - nesquena#1727 (@Michaelyklam) — link Claude Code OAuth in onboarding (closes nesquena#1362) - nesquena#1728 (@starship-s) — preserve profile context when starting chats - nesquena#1729 (@Michaelyklam) — persist compact Activity disclosure state - nesquena#1730 (@Michaelyklam) — prevent sticky sidebar hover drag state - nesquena#1732 (@Sanjays2402) — unpin scroll on small upward motion during streaming (closes nesquena#1731) Plus 2 in-stage absorbed fixes: - test-isolation fix: monkeypatch.setattr(config, 'cfg', X) survives PR nesquena#1728's path/mtime-aware get_config() reload. Mandatory before tag (Opus stage-302). - Opus SHOULD-FIX #1: _lastScrollTop reset on session switch (nesquena#1732 follow-up). Tests: 4537 → 4584 passing (+47). 0 regressions. Full suite ~128s. Stably green. Pre-release verification: - All 7 PRs CI-green individually + rebased onto master - pytest 4584 passed, 0 failed (multiple runs) - node -c clean on all 4 modified .js files - 11/11 browser API endpoints PASS on isolated port 8789 - 20 QA tests via webui_qa_agent.sh PASS - Opus advisor: SHIP, 5/5 verification clean, 0 MUST-FIX, 1 SHOULD-FIX absorbed (_lastScrollTop reset), 1 SHOULD-FIX deferred (nesquena#1736 — _clear_anthropic_env_values race, onboarding-time-only) Closes nesquena#1362, nesquena#1731.
Thinking Path
Activity: N tools, with details available only after expansion.What Changed
static/ui.js.static/style.css.DESIGN.mdto document the terse summary rule.tests/test_ui_tool_call_cleanup.pyfor the compact summary invariants.docs/pr-media/1725/.Why It Matters
This keeps successful tool/thinking activity quiet by default while preserving progressive disclosure for details. The transcript reads more like a chat and less like a debug console.
UI media
Before:
After:
Verification
test (3.11),test (3.12), andtest (3.13)are passing on commit443425da.Risks / Follow-ups
Model Used
OpenAI Codex / GPT-5.5 via Hermes Agent, with terminal/file/browser tooling and maintainer-autopilot PR stewardship.