fix: hot-apply compact tool activity setting#1590
Conversation
|
Thanks @Michaelyklam — small, targeted, and exactly the right kind of polish. Settings that silently wait for a refresh feel broken, and Compact tool activity is especially noticeable because it changes the transcript structure (Activity row vs individual tool cards), not just a stored boolean. Pulled and ran: Full sweep across A few notes on the change
One small worth-checking item The test asserts the strings Verdict Tight diff, solid coverage, sensible scope. Will queue for stage review. |
… — 4094→4111 tests - #1586 (Michaelyklam): login asset SW cache exemption - #1590 (Michaelyklam): hot-apply compact tool activity setting - #1591 (Michaelyklam): first-turn sidebar visibility (optimistic upserts) - #1592 (Michaelyklam): turn duration display (Done in 1m 12s) + Opus follow-up (truthy-check on _pending_started_at) - #1464 (JKJameson, maintainer-augmented): workspace dropdown sort+search+chip-sync (rebased + ternary fix + regression test) Maintainer-side test fixes in stage: - tests/test_465_session_branching.py: widen compact() search window 1500→3000 - tests/test_regressions.py: anchor on api('/api/chat/start' instead of comment line Browser API sanity: 11/11 passed. Live UX verification: vision-confirmed dropdown sort+search+empty-state on test server. Opus advisor: SHIP AS-IS.
4559163
Thinking Path
simplified_tool_callingbut did not update the live renderer flag or invalidate cached transcript HTML.What Changed
static/panels.jsso preferences autosave captures the saved settings response.simplified_tool_callingis part of the autosaved payload, the open tab now updateswindow._simplifiedToolCalling, clears the message render cache, and rerenders messages immediately.tests/test_ui_tool_call_cleanup.pyproving the autosave path hot-applies the renderer mode.Why It Matters
A settings checkbox that silently waits for a refresh feels broken. Compact tool activity is especially noticeable because it changes transcript structure, not just a stored preference. Hot-applying the runtime flag and rerendering keeps settings behavior consistent with user expectations: save/toggle means visible now.
Verification
Result:
UI media, if applicable:
Risks / Follow-ups
Model Used
AI assisted.
gpt-5.5