fix: restore inflight session on bfcache pageshow#1480
Merged
1 commit merged intonesquena:masterfrom May 2, 2026
Merged
Conversation
nesquena-hermes
closed this pull request by merging all changes
into
nesquena:master
in
b8a346f
nesquena-hermes
pushed a commit
to ccqqlo/hermes-webui
that referenced
this pull request
May 2, 2026
nesquena-hermes
pushed a commit
to ccqqlo/hermes-webui
that referenced
this pull request
May 2, 2026
…267 follow-ups - CHANGELOG.md: v0.50.269 entry detailing nesquena#1478 nesquena#1479 nesquena#1480 - ROADMAP.md: bump to v0.50.269, 3847 tests collected - TESTING.md: bump header + total to 3847 nesquena#1478: nesquena APPROVED self-built bootstrap.py --foreground mode (closes nesquena#1458 Bug nesquena#1, +Opus follow-ups: XPC noise filter, executability guard) nesquena#1479: surgical follow-up to nesquena#1473 — Session.compact() now includes pending_user_message nesquena#1480: bfcache pageshow restores active session via loadSession + checkInflightOnBoot 3847 tests pass (+47 net). Opus advisor on stage diff: no blockers.
pull Bot
pushed a commit
to soitun/hermes-webui
that referenced
this pull request
May 3, 2026
…ix + P0 polish bundle (nesquena#1466 nesquena#1494 nesquena#1469 nesquena#1484 nesquena#1486) 3 PRs in this batch (3866 → 3874 tests, +8): - nesquena#1493 (@dso2ng) — sidebar Stop response cancels row's stream not active pane's (closes nesquena#1466, follow-up to nesquena#1480) - nesquena#1495 (self-built; reported by @insecurejezza in nesquena#1494) — state.db connection FD leak in sidebar polling (closes nesquena#1494, addresses Bug #2 of nesquena#1458) - nesquena#1492 (@bergeouss) — P0 bugfixes bundle: tool-card args readability + CLI rename persistence + scroll pinning + sw.js relative-path regression test (closes nesquena#1469 nesquena#1484 nesquena#1486) This release closes Bug #2 of the umbrella issue nesquena#1458. Bug #1 was closed by v0.50.269 (nesquena#1483) + v0.50.270 (nesquena#1487). Bug #3 (HTTP-unhealthy without FD exhaustion) is the remaining work item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadSession()path when a persistedpageshowevent resumes from BFCache.checkInflightOnBoot()after that restore so active in-flight markers keep the same reload-recovery behavior introduced by Fix batch session actions and in-flight reload recovery #1473.pageshowhandler instead of relying on a fixed character window.Context
This is the next small follow-up for #1466 after #1467 shipped in v0.50.267. #1473 already fixed normal reload recovery for in-flight sessions; this PR keeps the BFCache restore path aligned with that behavior without changing server-side persistence or cache policy.
The invariant is the same as #1466: the active pane is only a projection, and running state belongs to the session that owns the stream.
Test Plan
node --check static/boot.js static/sessions.js static/messages.jspython -m py_compile api/routes.py api/models.py api/agent_sessions.pypytest tests/test_1466_bfcache_inflight_reattach.py tests/test_1045_bfcache_layout_restore.py tests/test_inflight_stream_reuse.py tests/test_session_cross_tab_sync.py -qnon_ascii_added_lines=0Refs #1466