Fix session list pending message payload#1479
Merged
1 commit merged intonesquena:masterfrom May 2, 2026
Merged
Conversation
nesquena-hermes
closed this pull request by merging all changes
into
nesquena:master
in
b8a346f
nesquena-hermes
pushed a commit
to ccqqlo/hermes-webui
that referenced
this pull request
May 2, 2026
nesquena-hermes
pushed a commit
to ccqqlo/hermes-webui
that referenced
this pull request
May 2, 2026
…267 follow-ups - CHANGELOG.md: v0.50.269 entry detailing nesquena#1478 nesquena#1479 nesquena#1480 - ROADMAP.md: bump to v0.50.269, 3847 tests collected - TESTING.md: bump header + total to 3847 nesquena#1478: nesquena APPROVED self-built bootstrap.py --foreground mode (closes nesquena#1458 Bug nesquena#1, +Opus follow-ups: XPC noise filter, executability guard) nesquena#1479: surgical follow-up to nesquena#1473 — Session.compact() now includes pending_user_message nesquena#1480: bfcache pageshow restores active session via loadSession + checkInflightOnBoot 3847 tests pass (+47 net). Opus advisor on stage diff: no blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged PR #1473.
The frontend reload/sidebar recovery logic already checks both
active_stream_idandpending_user_message, but the/api/sessionslist payload still omittedpending_user_messagefromSession.compact(). That meant the sidebar filter could not reliably preserve zero-message in-flight sessions based on pending user text alone.This patch:
pending_user_messageto the compact session payload used by/api/sessions{0}placeholder comment requested in review next tot()string interpolationWhy this is separate
PR #1473 is already merged. This is the smallest follow-up patch to close the remaining backend payload gap identified in review.
Tests
I was able to verify the code path and keep the patch minimal, but I could not run
tests/test_issue856_session_streaming_state.pyto completion inside the current local sandbox becauseapi.configrejects the sandbox workspace during import-time default workspace resolution.The added test is a direct extension of the existing backend regression coverage in
tests/test_issue856_session_streaming_state.py.