fix: show profile home in status command#1380
fix: show profile home in status command#1380NocGeek wants to merge 2 commits intonesquena:masterfrom
Conversation
|
Looks targeted at #463 — closes the small gap between WebUI Cross-checked the approach against the existing codebase:
A couple of things to keep an eye on in review:
Small focused diff (3 prod lines + 14 test lines) refs an existing milestone-2 issue. Will defer merge to maintainer review. |
|
Thanks for the quick i18n follow-up — the second commit ( One small thing: I didn't spot a Russian ( Other than that, no change to the original review — small, focused, no |
|
Released as part of v0.50.252 — thanks @NocGeek! This PR was merged into the v0.50.252 release batch via #1387 alongside 5 other contributor fixes. The full CHANGELOG entry is at https://github.com/nesquena/hermes-webui/blob/master/CHANGELOG.md. Pre-release verification: 3507 pytest tests pass, full QA harness pass (20 structural + 11 browser API + 23 Agent Browser CDP), Opus mentor APPROVED with two non-blocking follow-ups applied during the release batch (force=True on agent redactor, debug-log on profile fallback). Closing this PR — the change is live on master. |
Summary
/api/session/status/statuscommand outputWhy
Milestone 2 issue #463 calls for
/statusparity with the CLI status/profile output. The command already showed model, profile, workspace, timestamps, and token usage, but the Hermes home/profile home path was still missing.This keeps the lookup profile-aware by using
get_hermes_home_for_profile()and does not mutate process-wideHERMES_HOME.Tests
python3 -m py_compile api/session_ops.py tests/test_session_ops.pynode --check static/commands.jsgit diff --checkpython -m pytest tests/test_session_ops.py tests/test_issue840_slash_echo.pypython -m pytest tests/test_session_ops.py tests/test_issue840_slash_echo.py tests/test_commands_endpoint.py tests/test_sprint1.py::test_stream_status_unknown_idLocal result:
45 passedRefs #463