fix: harden streaming scroll unpin behavior#1377
fix: harden streaming scroll unpin behavior#1377NocGeek wants to merge 1 commit intonesquena:masterfrom
Conversation
|
Thanks for the regression fix for #1360. Cross-checked against current
A couple of things worth manually confirming before merge:
The new |
|
Released as part of v0.50.252 — thanks @NocGeek! This PR was merged into the v0.50.252 release batch via #1387 alongside 5 other contributor fixes. The full CHANGELOG entry is at https://github.com/nesquena/hermes-webui/blob/master/CHANGELOG.md. Pre-release verification: 3507 pytest tests pass, full QA harness pass (20 structural + 11 browser API + 23 Agent Browser CDP), Opus mentor APPROVED with two non-blocking follow-ups applied during the release batch (force=True on agent redactor, debug-log on profile fallback). Closing this PR — the change is live on master. |
Summary
scrollToBottom()from queue-card paths while a stream is active; usescrollIfPinned()instead so user scroll position is respectedTests
node --check static/ui.jspython -m pytest tests/test_issue1360_streaming_scroll_hardening.py tests/test_issue677.py tests/test_mobile_layout.py::test_messages_touch_scrolling_hints_present tests/test_embedded_workspace_terminal.pyLocal result:
29 passed