fix: sync active session across tabs#1359
Closed
dso2ng wants to merge 1 commit intonesquena:masterfrom
Closed
Conversation
nesquena-hermes
pushed a commit
that referenced
this pull request
Apr 30, 2026
Adds a 'storage' event listener for the hermes-webui-session localStorage key. Idle tabs auto-load the new active session and re-render the sidebar; busy tabs show a toast and do not interrupt the active turn. Co-authored-by: Dennis Soong <[email protected]>
nesquena-hermes
added a commit
that referenced
this pull request
Apr 30, 2026
Bundles 5 community PRs: - #1355 feat(clarify): SSE long-connection (mirrors #1350 pattern, includes all correctness lessons) - #1356 fix: context window indicator overflow (live SSE fallback) + uploading status clear - #1357 fix: preserve imported session source metadata - #1358 fix: collapse sidebar session lineage rows - #1359 fix: sync active session across tabs Tests: 3444 passing (3411 -> 3444, +33)
Collaborator
|
Shipped in v0.50.249 (merge Production verified live at port 8787, Three guards verified: (1) skip if not the right localStorage key, (2) skip if already on this session, (3) skip and toast if Thanks @dso2ng! 🙏 |
GeoffBao
pushed a commit
to GeoffBao/hermes-webui
that referenced
this pull request
May 1, 2026
Adds a 'storage' event listener for the hermes-webui-session localStorage key. Idle tabs auto-load the new active session and re-render the sidebar; busy tabs show a toast and do not interrupt the active turn. Co-authored-by: Dennis Soong <[email protected]>
GeoffBao
pushed a commit
to GeoffBao/hermes-webui
that referenced
this pull request
May 1, 2026
Bundles 5 community PRs: - nesquena#1355 feat(clarify): SSE long-connection (mirrors nesquena#1350 pattern, includes all correctness lessons) - nesquena#1356 fix: context window indicator overflow (live SSE fallback) + uploading status clear - nesquena#1357 fix: preserve imported session source metadata - nesquena#1358 fix: collapse sidebar session lineage rows - nesquena#1359 fix: sync active session across tabs Tests: 3444 passing (3411 -> 3444, +33)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
localStorageactive-session key.What Changed
storageevent listener for thehermes-webui-sessionkey.Why It Matters
This reduces accidental writes into stale sessions when users switch between browser tabs while using the same Hermes WebUI instance.
Verification
pytest tests/test_session_cross_tab_sync.py tests/test_sprint9.py::test_sessions_js_served -qRisks / Follow-ups
Model Used
AI-assisted: OpenAI Codex GPT-5.5 via Hermes Agent tools.