fix: avoid duplicate header copy buttons#1324
Closed
dso2ng wants to merge 1 commit intonesquena:masterfrom
Closed
Conversation
Collaborator
|
Thanks for the targeted fix. The duplicate-button bug from #1096 came back specifically on language-header blocks because the existing guard only looked inside The fix in Small, low-risk, +19/-3. Looks good to merge after CI. |
bsgdigital
pushed a commit
to bsgdigital/hermes-webui
that referenced
this pull request
Apr 30, 2026
From PR nesquena#1324. Co-authored-by: Dennis Soong <[email protected]>
GeoffBao
pushed a commit
to GeoffBao/hermes-webui
that referenced
this pull request
May 1, 2026
From PR nesquena#1324. Co-authored-by: Dennis Soong <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
.pre-header, not inside the<pre>element.<pre>, so repeatedaddCopyButtons()calls could append duplicate header copy buttons.What Changed
.code-copy-btnin the.pre-headersibling before creating a new copy button.document.createElement('button').Why It Matters
Verification
python -m pytest tests/test_issue1096_copy_buttons.py -q10 passedRisks / Follow-ups
Model Used