fix(workspace): Allow /var/home workspaces#1199
Closed
frap129 wants to merge 1 commit intonesquena:masterfrom
Closed
fix(workspace): Allow /var/home workspaces#1199frap129 wants to merge 1 commit intonesquena:masterfrom
frap129 wants to merge 1 commit intonesquena:masterfrom
Conversation
nesquena-hermes
added a commit
that referenced
this pull request
Apr 28, 2026
fix(workspace): Allow /var/home workspaces (#1199) Carries code from @frap129's PR #1199. On systemd-homed (Fedora/RHEL), home lives under /var/home/<user> — blocked by _is_blocked_system_path because /var is in the blocked roots list. Fix: trust any path under Path.home() as long as home != /. Also adds symmetric early-return in validate_workspace_to_add. 2764 tests pass. Co-authored-by: Joe Maples <[email protected]>
Collaborator
nesquena-hermes
added
bug
Collaborator
|
Root cause confirmed: on systemd-homed Fedora/RHEL, The fix is correct: removing This is a clean, targeted fix — low risk, affects only Fedora/RHEL systemd-homed users. Labelled |
JKJameson
pushed a commit
to JKJameson/hermes-webui
that referenced
this pull request
Apr 29, 2026
fix(workspace): Allow /var/home workspaces (nesquena#1199) Carries code from @frap129's PR nesquena#1199. On systemd-homed (Fedora/RHEL), home lives under /var/home/<user> — blocked by _is_blocked_system_path because /var is in the blocked roots list. Fix: trust any path under Path.home() as long as home != /. Also adds symmetric early-return in validate_workspace_to_add. 2764 tests pass. Co-authored-by: Joe Maples <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the pointless guard on home path checks to make /var/home and other alternate home paths work as workspaces. I just fixed this in #1165 and it was almost immediately broken.