fix: load custom models for known providers from config#1161
Closed
ccqqlo wants to merge 1 commit intonesquena:masterfrom
Closed
fix: load custom models for known providers from config#1161ccqqlo wants to merge 1 commit intonesquena:masterfrom
ccqqlo wants to merge 1 commit intonesquena:masterfrom
Conversation
Collaborator
|
Thanks for the fix, @ccqqlo! This is a clean solution to a real config-loading gap. The two-part fix is well-targeted:
The fix is minimal (2 lines changed) and the description clearly traces the original bug through the code path. Having local test confirmation that standard + custom OpenAI models merge correctly in the UI selector is good to hear. One thought: if you want to add a regression test for the deep-copy behavior (e.g., verifying that calling |
nesquena-hermes
added a commit
that referenced
this pull request
Apr 27, 2026
Merged as v0.50.227. 2634 tests passing, browser QA 21/21 (desktop + mobile). Full attribution below. Thanks to all 12 contributors: @jundev0001 (#1138), @franksong2702 (#1142, #1157, #1162), @dso2ng (#1143), @bergeouss (#1145, #1146, #1156, #1159), @jasonjcwu (#1149), @ccqqlo (#1161), @frap129 (#1165) Two fixes applied during integration and two more by the independent reviewer (@nesquena): - messages.js: per-turn cost delta capture order (#1159) - workspace.py: symlink target blocked-roots check + HOME sanity guard (#1149, #1165) - panels.js: cron unread counter bookkeeping (in-loop increment bug) - tests/test_symlink_cycle_detection.py: register workspace before session/new
Collaborator
JKJameson
pushed a commit
to JKJameson/hermes-webui
that referenced
this pull request
Apr 29, 2026
Merged as v0.50.227. 2634 tests passing, browser QA 21/21 (desktop + mobile). Full attribution below. Thanks to all 12 contributors: @jundev0001 (nesquena#1138), @franksong2702 (nesquena#1142, nesquena#1157, nesquena#1162), @dso2ng (nesquena#1143), @bergeouss (nesquena#1145, nesquena#1146, nesquena#1156, nesquena#1159), @jasonjcwu (nesquena#1149), @ccqqlo (nesquena#1161), @frap129 (nesquena#1165) Two fixes applied during integration and two more by the independent reviewer (@nesquena): - messages.js: per-turn cost delta capture order (nesquena#1159) - workspace.py: symlink target blocked-roots check + HOME sanity guard (nesquena#1149, nesquena#1165) - panels.js: cron unread counter bookkeeping (in-loop increment bug) - tests/test_symlink_cycle_detection.py: register workspace before session/new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The WebUI currently ignores custom models defined in
config.yamlwhen using a known provider (e.g.,openai).Problem
In
api/config.py, when resolving available models:if _pid_key in _PROVIDER_MODELS, skipping known providers that have custom configurations.raw_modelsaccesses_PROVIDER_MODELS.get(pid, [])directly by reference. This causes subsequent model updates to modify the global default models dictionary, leading to unexpected behavior and duplication in the WebUI selector.Solution
cfg.get('providers', {}).copy.deepcopy()when extracting from_PROVIDER_MODELSto prevent mutation of the global dictionary when custom models are appended.This allows users to configure custom models for standard providers like
openaivia theirconfig.yamland correctly see them in the WebUI.Tested locally and confirmed the UI properly merges standard + custom OpenAI models.