Normalize auto-compression transcript cards#1142
Closed
franksong2702 wants to merge 2 commits intonesquena:masterfrom
Closed
Normalize auto-compression transcript cards#1142franksong2702 wants to merge 2 commits intonesquena:masterfrom
franksong2702 wants to merge 2 commits intonesquena:masterfrom
Conversation
Contributor
Author
Collaborator
|
Thanks for this PR, @franksong2702 (and for the visual validation screenshots)! This is a well-structured normalization pass. Scope covers the three consistency gaps:
Key design properties maintained:
Tests: On not closing #524: Reasonable — #524 now covers broader compression UX guidance and this PR is one step in that direction. Flagging for maintainer review and merge. 🙏 |
nesquena-hermes
added a commit
that referenced
this pull request
Apr 27, 2026
Merged as v0.50.227. 2634 tests passing, browser QA 21/21 (desktop + mobile). Full attribution below. Thanks to all 12 contributors: @jundev0001 (#1138), @franksong2702 (#1142, #1157, #1162), @dso2ng (#1143), @bergeouss (#1145, #1146, #1156, #1159), @jasonjcwu (#1149), @ccqqlo (#1161), @frap129 (#1165) Two fixes applied during integration and two more by the independent reviewer (@nesquena): - messages.js: per-turn cost delta capture order (#1159) - workspace.py: symlink target blocked-roots check + HOME sanity guard (#1149, #1165) - panels.js: cron unread counter bookkeeping (in-loop increment bug) - tests/test_symlink_cycle_detection.py: register workspace before session/new
Collaborator
|
Merged as v0.50.227 via batch PR #1168. Thank you @franksong2702! 🎉 |
JKJameson
pushed a commit
to JKJameson/hermes-webui
that referenced
this pull request
Apr 29, 2026
Merged as v0.50.227. 2634 tests passing, browser QA 21/21 (desktop + mobile). Full attribution below. Thanks to all 12 contributors: @jundev0001 (nesquena#1138), @franksong2702 (nesquena#1142, nesquena#1157, nesquena#1162), @dso2ng (nesquena#1143), @bergeouss (nesquena#1145, nesquena#1146, nesquena#1156, nesquena#1159), @jasonjcwu (nesquena#1149), @ccqqlo (nesquena#1161), @frap129 (nesquena#1165) Two fixes applied during integration and two more by the independent reviewer (@nesquena): - messages.js: per-turn cost delta capture order (nesquena#1159) - workspace.py: symlink target blocked-roots check + HOME sanity guard (nesquena#1149, nesquena#1165) - panels.js: cron unread counter bookkeeping (in-loop increment bug) - tests/test_symlink_cycle_detection.py: register workspace before session/new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Thinking Path
/compressalready had a clearer compression-card presentation.Refs #524.
What Changed
S.messages.[CONTEXT COMPACTION — REFERENCE ONLY]messages asContext compactionreference cards across roles.Preserved task listcompression-adjacent card instead of a normal user bubble.donehandler regression test so it reads the full handler instead of relying on a brittle fixed-width slice.Why It Matters
Verification
.venv_test/bin/pytest tests/test_auto_compression_card.py tests/test_sprint46.py tests/test_regressions.py::test_done_handler_sets_busy_false_before_renderMessages -qnode --check static/ui.jsnode --check static/messages.jsnode --check static/i18n.jsgit diff --checkManual browser validation:
Automatic compressioncard.Context compactionartifact renders as a reference card.Preserved task listartifact renders as a compression-adjacent card.Risks / Follow-ups
Model Used