Improve Korean locale settings translations#1138
Closed
jundev0001 wants to merge 1 commit intonesquena:masterfrom
Closed
Improve Korean locale settings translations#1138jundev0001 wants to merge 1 commit intonesquena:masterfrom
jundev0001 wants to merge 1 commit intonesquena:masterfrom
Conversation
Collaborator
|
Thanks for this follow-up Korean locale PR, @jundev0001! 🇰🇷 Scope looks well-targeted:
Key count parity confirmed:
Test plan looks reasonable — Note on full suite: Understood that the full WebUI pytest suite was not run due to the WSL/production-config concern — the maintainer will likely run it before merge. This is a clean, focused locale-only change (no RTL/CSS changes, no logic changes). It follows the same pattern as #1119 (v0.50.222). Flagging for maintainer review and merge. 🙏 |
nesquena-hermes
added a commit
that referenced
this pull request
Apr 27, 2026
Merged as v0.50.227. 2634 tests passing, browser QA 21/21 (desktop + mobile). Full attribution below. Thanks to all 12 contributors: @jundev0001 (#1138), @franksong2702 (#1142, #1157, #1162), @dso2ng (#1143), @bergeouss (#1145, #1146, #1156, #1159), @jasonjcwu (#1149), @ccqqlo (#1161), @frap129 (#1165) Two fixes applied during integration and two more by the independent reviewer (@nesquena): - messages.js: per-turn cost delta capture order (#1159) - workspace.py: symlink target blocked-roots check + HOME sanity guard (#1149, #1165) - panels.js: cron unread counter bookkeeping (in-loop increment bug) - tests/test_symlink_cycle_detection.py: register workspace before session/new
Collaborator
|
Merged as v0.50.227 via batch PR #1168. Thank you @jundev0001! 🎉 |
JKJameson
pushed a commit
to JKJameson/hermes-webui
that referenced
this pull request
Apr 29, 2026
Merged as v0.50.227. 2634 tests passing, browser QA 21/21 (desktop + mobile). Full attribution below. Thanks to all 12 contributors: @jundev0001 (nesquena#1138), @franksong2702 (nesquena#1142, nesquena#1157, nesquena#1162), @dso2ng (nesquena#1143), @bergeouss (nesquena#1145, nesquena#1146, nesquena#1156, nesquena#1159), @jasonjcwu (nesquena#1149), @ccqqlo (nesquena#1161), @frap129 (nesquena#1165) Two fixes applied during integration and two more by the independent reviewer (@nesquena): - messages.js: per-turn cost delta capture order (nesquena#1159) - workspace.py: symlink target blocked-roots check + HOME sanity guard (nesquena#1149, nesquena#1165) - panels.js: cron unread counter bookkeeping (in-loop increment bug) - tests/test_symlink_cycle_detection.py: register workspace before session/new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Korean (한국어)to native-only한국어Test Plan
node -c static/i18n.js/home/kkjop2/.hermes/hermes-agent/venv/bin/python -m pytest -q tests/test_korean_locale.py tests/test_language_precedence.py tests/test_chinese_locale.py한국어with valuekosetLocale('ko')storeshermes-lang = "ko"and setsdocument.documentElement.lang = "ko-KR"/insightssync, and password are shown in KoreanAdditional locale checks
enunique key count: 623kounique key count: 623ko: noneko: noneko: nonestatic/i18n.jsandtests/test_korean_locale.py.Note on full suite
This is a focused locale follow-up to the Korean locale work that was already shipped in v0.50.222 via #1119. I did not claim a clean full-suite result for this branch because local full WebUI pytest runs can mutate production Hermes config in this WSL setup; instead I ran the focused locale/static/browser checks above and verified the production Hermes model config remained
openai-codex/gpt-5.5afterward.