[codex] Show attention state for broken recurring cron jobs#1133
Closed
franksong2702 wants to merge 2 commits intonesquena:masterfrom
Closed
[codex] Show attention state for broken recurring cron jobs#1133franksong2702 wants to merge 2 commits intonesquena:masterfrom
franksong2702 wants to merge 2 commits intonesquena:masterfrom
Conversation
franksong2702
force-pushed
the
franksong2702/cron-needs-attention
branch
from
d5dba51 to
dff7082
Compare
nesquena-hermes
added
enhancement
Collaborator
|
Reviewed and cleared for merge queue. Detection logic is precise, tests are solid (Node-driven behavioral verification), all 6 existing locale blocks covered. One small absorb needed at integration time: the Korean locale ( |
Collaborator
|
Pushed
All Korean locale coverage tests pass (7/7). Branch is fully ready for the next batch release. |
This was referenced Apr 27, 2026
nesquena-hermes
added a commit
that referenced
this pull request
Apr 27, 2026
* feat: attention state for broken cron jobs + Korean i18n (#1133, @franksong2702) * fix: pytest state isolation for direct session saves (#1136, @franksong2702) * fix(#1095): image thumbnails in composer + lightbox in chat (#1135) * fix(css): restore cron attention + detail-alert rules overwritten by style.css merge (absorb) * docs: v0.50.225 release notes and version bump --------- Co-authored-by: nesquena-hermes <[email protected]>
Collaborator
|
Merged in v0.50.225 via PR #1137. Thank you @franksong2702 — great contribution (cron attention state for broken recurring jobs)! 🎉 |
JKJameson
pushed a commit
to JKJameson/hermes-webui
that referenced
this pull request
Apr 29, 2026
…#1137) * feat: attention state for broken cron jobs + Korean i18n (nesquena#1133, @franksong2702) * fix: pytest state isolation for direct session saves (nesquena#1136, @franksong2702) * fix(nesquena#1095): image thumbnails in composer + lightbox in chat (nesquena#1135) * fix(css): restore cron attention + detail-alert rules overwritten by style.css merge (absorb) * docs: v0.50.225 release notes and version bump --------- Co-authored-by: nesquena-hermes <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Hermes Agent can currently persist recurring cron jobs as
enabled=false,state=completed, andnext_run_at=nullwhen the scheduler cannot compute the next run. This WebUI change does not fix the scheduler; it prevents that anomalous persisted state from being presented as a normal user-disabled job.Refs NousResearch/hermes-agent#16265.
Validation
node --check static/panels.jsnode --check static/i18n.jspython -m pytest tests/test_cron_needs_attention.py -qpython -m pytest tests/test_korean_locale.py tests/test_russian_locale.py tests/test_spanish_locale.py -qpython -m pytest tests/test_cron_refresh_button_835.py tests/test_settings_navigation_and_detail_refresh.py -qpython -m pytest tests/test_sprint9.py::test_panels_js_served tests/test_sprint10.py::test_cron_history_button_in_panels_js tests/test_sprint10.py::test_cron_output_snippet_helper -qNote: pytest was run locally with the Hermes Agent venv because the system Python on this machine does not have pytest installed. A full local
python -m pytest tests/ -qrun was also attempted; it passed the locale and cron changes but hit unrelated machine-state-dependent failures in legacy API tests.