feat(#1116): composer placeholder reflects active profile name#1122
Closed
bergeouss wants to merge 1 commit intonesquena:masterfrom
Closed
feat(#1116): composer placeholder reflects active profile name#1122bergeouss wants to merge 1 commit intonesquena:masterfrom
bergeouss wants to merge 1 commit intonesquena:masterfrom
Conversation
When a named profile is active (not 'default'), the composer placeholder and title bar show the profile name (capitalised) instead of the global bot_name. Falls back to bot_name/'Hermes' for the default profile. - boot.js: applyBotName() checks S.activeProfile before _botName - panels.js: switchToProfile() calls applyBotName() after switch - Added 5 regression tests
Collaborator
Triage Review ✅Nice UX improvement! Profile-aware composer placeholder makes multi-profile setups much more intuitive. What it does:
Review notes:
Looks good to merge. 🟢 |
Collaborator
|
Absorbed and shipped in v0.50.223 (PR #1127). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1116
When a named profile is active (not
'default'), the composer placeholder and title bar show the profile name (capitalised) instead of the globalbot_name. Falls back tobot_name/'Hermes'for the default profile.Changes
static/boot.js:applyBotName()now checksS.activeProfile— if set and not'default', uses the capitalised profile name. Falls back towindow._botNameotherwise.static/panels.js:switchToProfile()callsapplyBotName()after profile switch to update placeholder/title/sidebar/logo.tests/test_issue1116_composer_placeholder.py: 5 regression testsTesting