fix(#1103): show reasoning chip on page load, not only after session load#1114
Closed
bergeouss wants to merge 1 commit intonesquena:masterfrom
Closed
fix(#1103): show reasoning chip on page load, not only after session load#1114bergeouss wants to merge 1 commit intonesquena:masterfrom
bergeouss wants to merge 1 commit intonesquena:masterfrom
Conversation
…session load - Call fetchReasoningChip() during boot initialization, before session load - Chip now visible immediately with 'Default' label, updates when session loads - Add 7 JS source analysis tests
nesquena-hermes
added
bug
Collaborator
|
Clean fix with the right diagnostic path — the reasoning chip staying hidden until a session click was a genuine UX gap. Code review:
One note: The boot call uses the current API state to determine reasoning effort level. If the server returns a non-null effort (e.g. This PR is included in the v0.50.222 batch (#1119). Good contribution @bergeouss! |
nesquena-hermes
added a commit
that referenced
this pull request
Apr 26, 2026
…SRI (#1119) * feat: add Korean locale support (#1093, @jundev0001) — 615 keys, copy_failed added * fix(#1094): provider deletion + false positive API key + threading deadlock (#1102, @bergeouss) * fix(#1103): show reasoning chip on page load not only after session load (#1114, @bergeouss) * fix(#1100): remove Prism CSS SRI integrity to fix intermittent blocking (#1115, @bergeouss) * fix(tests): update copy_failed locale count for 7 locales (Korean added) * fix: drop unused _cfg_cache import; update locale count comment --------- Co-authored-by: nesquena-hermes <[email protected]>
Collaborator
|
Absorbed and shipped in v0.50.222 (PR #1119). Closing — thanks! |
JKJameson
pushed a commit
to JKJameson/hermes-webui
that referenced
this pull request
Apr 29, 2026
…SRI (nesquena#1119) * feat: add Korean locale support (nesquena#1093, @jundev0001) — 615 keys, copy_failed added * fix(nesquena#1094): provider deletion + false positive API key + threading deadlock (nesquena#1102, @bergeouss) * fix(nesquena#1103): show reasoning chip on page load not only after session load (nesquena#1114, @bergeouss) * fix(nesquena#1100): remove Prism CSS SRI integrity to fix intermittent blocking (nesquena#1115, @bergeouss) * fix(tests): update copy_failed locale count for 7 locales (Korean added) * fix: drop unused _cfg_cache import; update locale count comment --------- Co-authored-by: nesquena-hermes <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
style="display:none"in HTML (correct — avoids FOUC)_currentReasoningEffortstarts asnull— chip stays hiddenfetchReasoningChip()is only called fromsyncReasoningChip(), which is only triggered during session renderfetchReasoningChip()during boot initialization, before session loadWhat Changed
static/boot.js: AddedfetchReasoningChip()call in the async boot IIFE, just before the saved session load. Guarded withtypeofcheck. The chip now fetches the current reasoning effort from the API and displays it immediately.Why It Matters
Users couldn't see or interact with the reasoning chip until they loaded a session. This was confusing — the chip appeared only after clicking on a conversation. Now it's visible from the start, showing the current reasoning effort level.
Verification
pytest tests/test_issue1103_reasoning_chip_visibility.py -v— 7/7 passModel Used
Closes #1103