Add embedded workspace terminal#1099
Closed
franksong2702 wants to merge 11 commits intonesquena:masterfrom
Closed
Conversation
Contributor
|
Still discussing this in discord <3 |
added 11 commits
April 28, 2026 19:28
b787771 to
20cb351
Compare
Contributor
Author
Collaborator
Hold — awaiting @aronprins UX sign-offThanks for the updates, @franksong2702! The implementation direction looks great and the visual updates are appreciated. We're currently waiting for explicit UX approval from @aronprins before this can proceed to technical review. The last Discord discussion (April 27) noted this was still being discussed. @aronprins — once you've had a chance to review the updated screenshots and implementation direction, please post an approval comment here when you're happy with the UX approach. We'll proceed with the full technical review immediately after. |
Collaborator
|
Merged in v0.50.237 via #1243. Thank you @franksong2702! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Thinking Path
Hermes WebUI needs a power-user path for running quick workspace commands without leaving the active conversation. The feature is useful only if it preserves the chat workflow instead of turning the composer into a crowded control strip.
This PR originally explored a composer-adjacent terminal. After Aron’s Discord feedback and the UI/UX philosophy doc, the implementation pivoted:
/terminalis the V1 entry pointUI/UX Alignment
This follows the direction in Aron’s UI/UX philosophy:
/terminalkeeps the feature reachable without making every user see it all the time.Alternatives considered and rejected:
What Changed
/terminalslash command that opens the workspace terminal.Visual Validation Notes
The latest local visual pass covered these states:
/teshows/terminalas a command option without adding a permanent composer icon.lsandpwdrender inside the xterm surface with readable dark-theme output.Why It Matters
cd-ing into the active workspace.Technical Notes
subprocess.run, so prompts, ANSI output, interactive programs, and resize behavior work like a real shell.os.environ.Verification
Passed:
Result:
Additional verification already performed during the PR iteration:
Full-suite note:
pytest tests/ -v --timeout=60command could not run in this local environment because thepytest-timeoutplugin is not installed here.Risks / Follow-ups
Model Used