Skip to content

Conversation

@technomancy
Copy link
Contributor

This includes the original patch plus changes to the 3rd-party repo, as well adding a Fennel demo.

There is already a fair bit of duplication between Lua and Moonscript; this patch follows the example set by Moonscript, but this does introduce more duplication. If you like I can work on factoring out the common functions in a follow-up PR, in particular the repetition of loadedlibs in luaapi.c.

Fixes #594

Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks ok

@nesbox nesbox merged commit 010e983 into nesbox:master May 16, 2018
@nesbox nesbox added enhancement Improvement of existing feature or adding something new API Issues related to TIC80 API labels May 16, 2018
@nesbox nesbox added this to the 0.70.0 milestone May 16, 2018
@nesbox
Copy link
Owner

nesbox commented May 16, 2018

Thank you 👍

@nesbox
Copy link
Owner

nesbox commented May 16, 2018

Ahh, one more thing, please, don't forget to add yourself to the Credits list here https://github.com/nesbox/TIC-80/wiki#credits

@technomancy technomancy deleted the fennel branch May 16, 2018 15:28
@technomancy
Copy link
Contributor Author

Thanks; will do! I'll take a look at updating the documentation too. Is that all on the wiki, or is there anything in the main repo to update?

@nesbox
Copy link
Owner

nesbox commented May 16, 2018

only on the wiki so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Issues related to TIC80 API enhancement Improvement of existing feature or adding something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants