Skip to content

Disable PoolPersisted on windows CI #4431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quake merged 1 commit into from
Apr 22, 2024
Merged

Disable PoolPersisted on windows CI #4431

quake merged 1 commit into from
Apr 22, 2024

Conversation

@eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Apr 22, 2024

What problem does this PR solve?

It's hard to let PoolPersisted execute on windows, disable it now, fix later...

What is changed and how it works?

Related changes

  • Disable PoolPersisted on windows integration test

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner April 22, 2024 12:03
@eval-exec eval-exec requested review from quake and zhangsoledad and removed request for a team April 22, 2024 12:03
@quake quake added this pull request to the merge queue Apr 22, 2024
Merged via the queue into nervosnetwork:develop with commit 30723e6 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quake quake quake approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eval-exec @quake