Conversation
| let s:stderr = {} | ||
| let s:job_opts = {'rpc': v:true} | ||
|
|
||
| function! s:job_opts.on_stderr(chan_id, data, event) |
There was a problem hiding this comment.
Use provider#stderr_collector, see https://github.com/neovim/neovim/blob/master/runtime/autoload/provider.vim
| endif | ||
| call health#report_info('Host: '. host) | ||
|
|
||
| let latest_npm_cmd = has('win32') ? 'cmd /c npm info neovim --json' : 'npm info neovim --json' |
There was a problem hiding this comment.
should not need a separate command for Windows, I believe the ruby check does it that way because of the different quoting. (Though it may possibly be unnecessary there as well, since system([...]) is called with a list.)
There was a problem hiding this comment.
Safe to use same command in Windows. Nevermind. npm.cmd calls npm node in the same directory. npm in Windows is a shell script.
There was a problem hiding this comment.
It's the same case for ruby, I think I recall.
There was a problem hiding this comment.
(This used ruby's provider script as a template)
bfredl
added
provider
remote-plugin
|
@billyvg still WIP? |
|
@justinmk Nope, I think it's good. |
| return | ||
| endif | ||
|
|
||
| if !executable('node') || !executable('npm') || !executable('yarn') |
There was a problem hiding this comment.
why is yarn a requirement, @billyvg ?
There was a problem hiding this comment.
Oops, it shouldn't be, it seems I didn't pull in neovim/node-host@40c370a
FEATURES: b6a603f neovim#7458 node.js remote-plugin support f5d4da0 :checkhealth : validate 'runtimepath' (neovim#7526) FIXES: e6beb60 :terminal : fix crash on resize (neovim#7547) 07931ed tui: 'guicursor': use DECSCUSR for xterm-likes (neovim#7576) f185c73 neovim#7561 'os_open: UV_EINVAL on NULL filename' e8af34d win: provider: Detect(): return *.cmd path (neovim#7577) eacd788 :checkhealth : fix check for npm and yarn (neovim#7569) a43a573 health.vim: normalize slashes for script path (neovim#7525) 69e3308 cmake: install runtime/rgb.txt d0b05e3 runtime: Fix syntax error in `runtime/syntax/tex.vim` (neovim#7518) 55d8967 tutor: some fixes (neovim#7510) CHANGES: 9837a9c remove legacy alias to `v:count` (neovim#7407) c5f001a runtime: revert netrw update (neovim#7557) 67e4529 defaults: scrollback=10000 (neovim#7556) 881f9e4 process_close(): uv_unref() detached processes (neovim#7539)
FEATURES: a6de144 'viewoptions': add "curdir" flag neovim#7447 b6a603f node.js remote-plugin support neovim#7458 f5d4da0 :checkhealth : validate 'runtimepath' neovim#7526 FIXES: e6beb60 :terminal : fix crash on resize neovim#7547 f19e5d6 work around gnome-terminal memory leak neovim#7573 07931ed 'guicursor': use DECSCUSR for xterm-likes neovim#7576 f185c73 'os_open: UV_EINVAL on NULL filename' neovim#7561 e8af34d win: provider: Detect(): return *.cmd path neovim#7577 eacd788 :checkhealth : fix check for npm and yarn neovim#7569 a43a573 health.vim: normalize slashes for script path neovim#7525 69e3308 cmake: install runtime/rgb.txt d0b05e3 runtime: syntax error in `runtime/syntax/tex.vim` neovim#7518 55d8967 tutor: some fixes neovim#7510 CHANGES: 9837a9c remove legacy alias to `v:count` neovim#7407 c5f001a runtime: revert netrw update neovim#7557 67e4529 defaults: scrollback=10000 neovim#7556 881f9e4 process_close(): uv_unref() detached processes neovim#7539
|
I can't find any functional tests for node provider in https://github.com/neovim/neovim/tree/master/test/functional/provider. |
|
@janlazo There aren't any. Would be nice to have a couple. |
|
Any docs to refer to? There's no VimL sugar for node provider so I can't think of a test case for |
|
Is it impossible to write a one-liner test for node host through VimL? |
|
I don't know. Maybe @billyvg can comment. |
|
@janlazo you can try the example mentioned here: neovim/node-client#43 |
|
I tried that with some changes (run |
6 participants
This adds support for node.js as a remote host, also adds health check.