Repository navigation
fix(editorconfig): "?" glob matches "/" - #42671
Merged
Merged
Conversation
Problem: EditorConfig "?" matches any single character except "/", but glob2regpat() turns it into ".", so "[som?.c]" also applies to "som/.c". Solution: Replace "?" with "[^/]", the same way single "*" becomes "[^/]*". AI-assisted
Member
b84330808
marked this pull request as ready for review
November 4, 2026 16:26
gpanders
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In EditorConfig,
?matches any single character except/(https://spec.editorconfig.org/#glob-expressions). Nvim'sglob2regpat()turns it into., so[som?.c]also applies tosom/.c. This is thequestion_slashcase in editorconfig-core-test.Solution
Replace an unescaped
?with[^/], using a placeholder the same way a single*becomes[^/]*. Added a"?" glob does not match "/"case totest/functional/plugin/editorconfig_spec.lua. It fails without the change and passes with it.AI-assisted: this change was written with an AI coding agent.