ci(uncrustify): lint codebase with uncrustify #18563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dundargoc
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
justinmk
reviewed
May 13, 2022
dundargoc
force-pushed
the
ci/uncrustify
branch
2 times, most recently
from
f6d7d37 to
3a0d73c
Compare
justinmk
pushed a commit
that referenced
this pull request
May 15, 2022
uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also #18563
Member
|
😃 |
justinmk
reviewed
May 15, 2022
justinmk
approved these changes
May 15, 2022
Member
|
off topic: why does the lint job build |
mhinz
added a commit
to mhinz/neovim
that referenced
this pull request
May 15, 2022
uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
This comment was marked as off-topic.
This comment was marked as off-topic.
mhinz
added a commit
that referenced
this pull request
May 15, 2022
uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also #18563
kylo252
reviewed
May 16, 2022
dundargoc
force-pushed
the
ci/uncrustify
branch
2 times, most recently
from
7a1fc02 to
e1354b7
Compare
clason
reviewed
May 16, 2022
Shougo
pushed a commit
to Shougo/neovim
that referenced
this pull request
May 22, 2022
This lint job will ensure that the C codebase is properly formatted at all times. This helps eliminate most of clint.py. To save CI time, it's faster to manually compile uncrustify and cache the binary instead of using homebrew (the apt-get package is too old).
Shougo
pushed a commit
to Shougo/neovim
that referenced
this pull request
May 22, 2022
…8611 Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563 Closes neovim#17763
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 22, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 22, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
justinmk
pushed a commit
that referenced
this pull request
May 22, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also #18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 26, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 27, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 27, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 27, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 27, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 27, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 27, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 27, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 27, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 28, 2022
Uncrustify is the source of truth where possible. See also neovim#18563
justinmk
pushed a commit
that referenced
this pull request
May 31, 2022
Uncrustify is the source of truth where possible. See also #18563
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
…#18584) uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
This lint job will ensure that the C codebase is properly formatted at all times. This helps eliminate most of clint.py. To save CI time, it's faster to manually compile uncrustify and cache the binary instead of using homebrew (the apt-get package is too old).
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
…8611 Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563 Closes neovim#17763
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
Uncrustify is the source of truth where possible. See also neovim#18563
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
Oct 30, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also neovim#18563
justinmk
pushed a commit
that referenced
this pull request
Nov 1, 2022
Uncrustify is the source of truth where possible. Remove any redundant checks from clint.py. See also #18563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint job will ensure that the C codebase is properly formatted atall. This will help us get rid of the automatable parts of clint as well as reducing a lot of noise from the dev-style section in the documentation.