DNM(experiment): sized typval strings #18339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows typval strings to contain NUL bytes in order for them to carry Lua strings.
lewis6991
changed the title
justinmk
reviewed
May 1, 2022
Member
|
Just for reference, another very interesting option we've discussed long ago, is to use SDS strings (or some similar thin string library) for all strings:
Rather than "all strings", introducing something like SDS only for Vimscript (initially) could be very feasible, because the lifetime of Vimscript strings is fairly simple: they get released when the typval gets destroyed. So we'd have little risk of a naive free() doing the wrong thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment/proof-of-concept for a suggestion in #18286
Allows typval strings to contain
NULbytes in order for them to carry Lua strings.v_sizetotypval_Twhich when set to>-1represents the size of the value. Currently only used forVAR_STRINGinf_iconv.Lua string's intotypval Blob's. This was previously done because Lua strings can containNULbytes whereas typval strings cannot so convertion to Blob instead was needed to properly represent the object.v_sizeis set to a sensible value.