fix(mac): use same $LANG fallback mechanism as Vim #18294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
build
mhinz
force-pushed
the
mac/simpler-locale-fallback
branch
from
dc26491 to
40f0c2d
Compare
mhinz
changed the title
In a locale "en_US", "en" is the language and "US" is the region. Before this change, we were too clever for our own good and tried to handle the region as well. But if the macOS primary language is set to "English" and the region to "Norway", we would end up with "en_NO", which is a locale that does not exist. Now we only take the language into account. Taking the example from above would yield "en_US", which is a sensible fallback. If the region is important to you, set $LANG and the more specific LC_* variables in your shell config or alternatively use `:help :language`. References neovim#18292
mhinz
force-pushed
the
mac/simpler-locale-fallback
branch
from
40f0c2d to
e038625
Compare
mhinz
commented
Apr 28, 2022
| ELOG("$LANG is empty and the macOS primary language cannot be inferred."); | ||
| } | ||
| CFRelease(cf_lang_region); | ||
| # ifdef HAVE_LOCALE_H |
Contributor
Author
There was a problem hiding this comment.
I deliberately left out the checks for HAVE_LOCALE_H and LC_NUMERIC, because I think it's not needed within __APPLE__.
mhinz
changed the title
clason
added
platform:macos
localization
Member
|
Looks fine to me, and fixes the linked issue! @jamessan what do you think? |
Contributor
Author
|
James mentioned that he's on vacation right now, so we should give him a few days to respond. :) |
Member
|
Yup, just wanted to let him know that I'll merge it only(!) when he's looked at it and given his thumbs-up. |
clason
approved these changes
Apr 29, 2022
Contributor
|
Successfully created backport PR #18351 for |
clason
added a commit
that referenced
this pull request
Jun 19, 2022
Problem: The release script bundles a system library (CoreServices) that was added in #18294, which leads to errors on M1 since the architecture is different from the Github runner. Solution: Skip CoreServices when bundling the libraries (as was done for the CoreFoundation library that #18294 replaced with CoreServices).
clason
added a commit
that referenced
this pull request
Jun 19, 2022
Problem: The release script bundles a system library (CoreServices) that was added in #18294, which leads to errors on M1 since the architecture is different from the Github runner. Solution: Skip CoreServices when bundling the libraries (as was done for the CoreFoundation library that #18294 replaced with CoreServices).
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jul 6, 2022
Problem: The release script bundles a system library (CoreServices) that was added in neovim#18294, which leads to errors on M1 since the architecture is different from the Github runner. Solution: Skip CoreServices when bundling the libraries (as was done for the CoreFoundation library that neovim#18294 replaced with CoreServices).
smjonas
pushed a commit
to smjonas/neovim
that referenced
this pull request
Dec 31, 2022
Problem: The release script bundles a system library (CoreServices) that was added in neovim#18294, which leads to errors on M1 since the architecture is different from the Github runner. Solution: Skip CoreServices when bundling the libraries (as was done for the CoreFoundation library that neovim#18294 replaced with CoreServices).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a locale "en_US", "en" is the language and "US" is the region.
Before this change, we were too clever for our own good and tried to handle the
region as well. But if the macOS primary language is set to "English" and the
region to "Norway", we would end up with "en_NO", which is a locale that does
not exist.
Now we only take the language into account. Taking the example from above would
yield "en_US", which is a sensible fallback.
If the region is important to you, set $LANG and the more specific LC_*
variables in your shell config or alternatively use
:help :language.References #18292