Skip to content

Conversation

@ashleyh
Copy link
Contributor

@ashleyh ashleyh commented Jan 31, 2014

I've just tweaked things until it builds (and the tests pass) on:

  • my Arch desktop
  • my OSX laptop
  • a fresh Ubuntu 12.04 (LTS) container
  • a fresh Ubuntu 13.10 container

There is some nonsense that means gettext has to be disabled on OSX for now.

@tarruda
Copy link
Member

tarruda commented Feb 1, 2014

I squashed and merged, thanks

@tarruda tarruda closed this Feb 1, 2014
Gaelan pushed a commit to Gaelan/neovim that referenced this pull request Feb 24, 2014
Convert src/mbyte.c to ANSI functions.
aktau referenced this pull request in aktau/neovim May 31, 2014
It was a false positive, but it can't hurt to "fix" it.

Original warning:
CID 13685 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
6. buffer_size: Calling strncpy with a source string whose length (4 chars)
is greater than or equal to the size argument (4) will fail to
null-terminate b0p->b0_version.
aktau referenced this pull request in aktau/neovim Jun 1, 2014
It was a false positive, but it can't hurt to "fix" it.

Original warning:
CID 13685 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
6. buffer_size: Calling strncpy with a source string whose length (4 chars)
is greater than or equal to the size argument (4) will fail to
null-terminate b0p->b0_version.
aktau referenced this pull request in aktau/neovim Jun 2, 2014
It was a false positive, but it can't hurt to "fix" it.

Original warning:
CID 13685 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
6. buffer_size: Calling strncpy with a source string whose length (4 chars)
is greater than or equal to the size argument (4) will fail to
null-terminate b0p->b0_version.
aktau referenced this pull request in aktau/neovim Jun 2, 2014
It was a false positive, but it can't hurt to "fix" it.

Original warning:
CID 13685 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
6. buffer_size: Calling strncpy with a source string whose length (4 chars)
is greater than or equal to the size argument (4) will fail to
null-terminate b0p->b0_version.
aktau referenced this pull request in aktau/neovim Jun 2, 2014
It was a false positive, but it can't hurt to "fix" it.

Original warning:
CID 13685 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
6. buffer_size: Calling strncpy with a source string whose length (4 chars)
is greater than or equal to the size argument (4) will fail to
null-terminate b0p->b0_version.
aktau referenced this pull request in aktau/neovim Jun 2, 2014
It was a false positive, but it can't hurt to "fix" it.

Original warning:
CID 13685 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
6. buffer_size: Calling strncpy with a source string whose length (4 chars)
is greater than or equal to the size argument (4) will fail to
null-terminate b0p->b0_version.
aktau referenced this pull request in aktau/neovim Jun 9, 2014
It was a false positive, but it can't hurt to "fix" it.

Original warning:
CID 13685 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
6. buffer_size: Calling strncpy with a source string whose length (4 chars)
is greater than or equal to the size argument (4) will fail to
null-terminate b0p->b0_version.
aktau added a commit that referenced this pull request Jun 12, 2014
It was a false positive, but it can't hurt to "fix" it.

Original warning:
CID 13685 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
6. buffer_size: Calling strncpy with a source string whose length (4 chars)
is greater than or equal to the size argument (4) will fail to
null-terminate b0p->b0_version.
@Kazark Kazark mentioned this pull request Sep 20, 2014
Grimy pushed a commit to Grimy/neovim that referenced this pull request Jan 7, 2015
@zaxebo1 zaxebo1 mentioned this pull request Jul 6, 2015
@buf1024 buf1024 mentioned this pull request Jul 18, 2015
haolian9 pushed a commit to haolian9/neovim that referenced this pull request Mar 13, 2024
A lot of code inside HAVE_WORKING_LIBINTL doesn't really depend on a
"working libintl". For instance ex_language is also used for ":lang collate"
and ":lang time".

Also ":lang C" should not fail just because translations aren't available (it
just means use the default text).

References:

neovim#1 2d00ead
separate ifdefs for locale and gettext got merged together.

neovim@8253e29
Unmotivated switcharoo of get_mess_env() logic. If available, get_locale_val(LC_MESSAGES) is the correct implementation.

(cherry picked from commit 3a44db5)
@izelnakri izelnakri mentioned this pull request Jun 18, 2024
justinmk pushed a commit that referenced this pull request Dec 18, 2024
…ders #31608

Problem:
regression since #31340

`nvim -l repro.lua`:
```lua
vim.lsp.start { cmd = { 'lua-language-server' }, name = 'lua_ls' }
vim.lsp.start { cmd = { 'lua-language-server' }, name = 'lua_ls', root_dir = 'foo' }

-- swapped case will be ok:
-- vim.lsp.start { cmd = { 'lua-language-server' }, name = 'lua_ls', root_dir = 'foo' }
-- vim.lsp.start { cmd = { 'lua-language-server' }, name = 'lua_ls' }
```

Failure:
```
E5113: Error while calling lua chunk: /…/lua/vim/lsp.lua:214: bad argument #1 to
'ipairs' (table expected, got nil)
stack traceback:
        [C]: in function 'ipairs'
        /…/lua/vim/lsp.lua:214: in function 'reuse_client'
        /…/lua/vim/lsp.lua:629: in function 'start'
        repro.lua:34: in main chunk
```
zeertzjq pushed a commit that referenced this pull request Feb 8, 2025
this change includes the following changes:
- a macro option must be #1#9
- add \providecommand
- add starred versions of \newcommand, \newenvironment, and their
  variants
- add number of arguments to \(re)newenvironment

vim/vim@a35040f

Co-authored-by: Eisuke Kawashima <[email protected]>
justinmk added a commit that referenced this pull request Jul 12, 2025
Problem:
Bad format() call on PUC Lua #34901

    Error: Failed to run healthcheck for "vim.health" plugin. Exception:
    runtime/lua/vim/health/health.lua:89: bad argument #1 to 'format' (string expected, got nil)

Solution:
Avoid passing nil.
github-actions bot pushed a commit that referenced this pull request Jul 12, 2025
Problem:
Bad format() call on PUC Lua #34901

    Error: Failed to run healthcheck for "vim.health" plugin. Exception:
    runtime/lua/vim/health/health.lua:89: bad argument #1 to 'format' (string expected, got nil)

Solution:
Avoid passing nil.

(cherry picked from commit 2422fbd)
justinmk added a commit that referenced this pull request Jul 12, 2025
Problem:
Bad format() call on PUC Lua

    Error: Failed to run healthcheck for "vim.health" plugin. Exception:
    runtime/lua/vim/health/health.lua:89: bad argument #1 to 'format' (string expected, got nil)

Solution:
Avoid passing nil.

(cherry picked from commit 2422fbd)

Co-authored-by: Justin M. Keyes <[email protected]>
justinmk added a commit that referenced this pull request Jul 13, 2025
Problem:
The "gitsigns" plugin runs `vim.diff` in a thread (`uv.new_work`), but
`vim.diff` is nil in that context:

    Lua callback:
    …/gitsigns.nvim/lua/gitsigns/diff_int.lua:30: bad argument #1 to 'decode' (string expected, got nil)
    stack traceback:
      [C]: in function 'decode'
      …/gitsigns.nvim/lua/gitsigns/diff_int.lua:30: in function <…/gitsigns.nvim/lua/gitsigns/diff_int.lua:29>
    Luv thread:
    …/gitsigns.nvim/lua/gitsigns/diff_int.lua:63: attempt to call field 'diff' (a nil value)

Solution:
Revert the `stdlib.c` change (set `vim.diff` instead of `vim._diff`).
ggandor added a commit to ggandor/neovim that referenced this pull request Nov 8, 2025
`scrolloff`, `conceallevel`, and `modeline` all get disabled by default.

Closes: neovim#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants