Merged
Conversation
Contributor
|
Code LGTM Regarding switching to upstream glutin, as per #1789 the only change we have is neovide/glutin@cf50967 (apart from one other macOS change that can be upstreamed), our winit fork (https://github.com/neovide/winit/tree/new-keyboard-v3) matches upstream, so we can move everything to upstream if we'd like (the PR linked above is currently broken on linux, but I believe the changes in this PR would fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This moves the Glutin context creation to it's own file. It also passes the winit window around rather than the whole context, so that the code mostly becomes dependent on winit rather than glutin.
The only direct reference to glutin is in the new
opengl.rsfile, but the context is still used outside of that, so some of the code is still dependent on it at an interface level.This is done mostly to make it easier to review my upcoming render changes. But it should also be quite easy to switch over to not use a forked version of Glutin anymore. The new Glutin versions, no longer depend on winit, so we can use our own version of it. Instead we could directly do something similar as the Glutin winit module https://github.com/rust-windowing/glutin/tree/master/glutin-winit/src
Did this PR introduce a breaking change?