TASK: Remove try catch block in Files::getFileContents#816
Closed
TASK: Remove try catch block in Files::getFileContents#816
Conversation
This change remove the try catch block, file_get_contents never throw an exception and definitively not a Flow exception. Maybe a left over after some refactoring ...
|
@dfeyer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kdambekalns, @kitsunet and @daniellienert to be potential reviewers. |
johannessteu
approved these changes
Jan 13, 2017
gerhard-boden
approved these changes
Jan 13, 2017
Member
|
But if it emits a warning, that will be converted into an exception by our settings, so… Did you check what happens with a non-readable file, e.g.? |
Collaborator
|
what @kdambekalns said |
Member
|
Maybe a test for that case would help :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change remove the try catch block, file_get_contents never throw an
exception and definitively not a Flow exception. Maybe a left over after
some refactoring ...