Skip to content

Add pdflatex-based tex maker.#1236

Closed
glacambre wants to merge 3 commits intoneomake:masterfrom
glacambre:master
Closed

Add pdflatex-based tex maker.#1236
glacambre wants to merge 3 commits intoneomake:masterfrom
glacambre:master

Conversation

@glacambre
Copy link
Copy Markdown
Contributor

No description provided.

@mention-bot
Copy link
Copy Markdown

@glacambre, thanks for your PR! By analyzing the history of the files in this pull request, we identified @natemara, @poohzrn and @languitar to be potential reviewers.

@blueyed
Copy link
Copy Markdown
Member

blueyed commented Apr 26, 2017

Thanks!
I've pushed some fixups. Please consider using a separate branch (and not master) for PRs in the future.

@blueyed blueyed closed this in a98d251 Apr 26, 2017
@blueyed
Copy link
Copy Markdown
Member

blueyed commented Apr 26, 2017

@aldur
Copy link
Copy Markdown

aldur commented Apr 28, 2017

@blueyed @glacambre now everytime a user runs :Neomake, pdflatex creates LaTeX auxiliary files in the current directory (i.e. aux, log, pdf, etc.).
This can be annoying for those that, like me, use latexmk and a custom build directory.

What do you guys think?
pdflatex supports specifying the output directory with the option -output-directory /tmp.
However, this is not portable.

@blueyed
Copy link
Copy Markdown
Member

blueyed commented Apr 28, 2017

However, this is not portable.

Because of using /tmp? Vim has tempname() that could be used.
Should it be stable across runs then? (at least for the same file)

@languitar
Copy link
Copy Markdown
Contributor

languitar commented Apr 28, 2017

Getting pdflatex to do real out-of-source builds is a real pain and simply defining --output-directory still breaks a ton of packages. I actually don't think that pdflatex is very useful as a maker without a proper front-end like latexmk just because of all the recompile loops LaTeX requires and potential calls to bibtex, biber, mkglossaries and whatever...

But @aldur, you are free to just disable the maker again by defining g:neomake_tex_enabled_makers. ;)

@aldur
Copy link
Copy Markdown

aldur commented Apr 28, 2017

@languitar, I agree about the usefulness and I disabled it, but I spent a few minutes to understand what was creating that files for me. Since it "pollutes" the user environment, it doesn't seem like a reasonable maker to be enabled by default.

@blueyed
Copy link
Copy Markdown
Member

blueyed commented Apr 28, 2017

it doesn't seem like a reasonable maker to be enabled by default.

Agreed.
It sounds we should not enable it by default, and also add --output-directory. Do you agree?

@blueyed
Copy link
Copy Markdown
Member

blueyed commented Apr 28, 2017

Can we use --output-directory /dev/null, or does it need to be a dir really?

@languitar
Copy link
Copy Markdown
Contributor

Depends on the use case, generally, I would say. If pdflatex is used for linting, that would be ok. Otherwise, if someone would really want to use this to produce a PDF, that would be a bad idea.

@blueyed
Copy link
Copy Markdown
Member

blueyed commented Apr 28, 2017

OK, disabled it for now, and added a note to https://github.com/neomake/neomake/wiki/Makers.
Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants